1665562 - 0.07 - 0.18% installer size (osx-shippable) regression on push 3618085622203ef418c62c3d99199485c99e0e51 (Fri September 11 2020)

Status: RESOLVED WONTFIX

(Core :: Graphics: WebRender, defect)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Perfherder has detected a build_metrics performance regression from push 3618085622203ef418c62c3d99199485c99e0e51. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

0.18% installer size osx-shippable opt instrumented 104,490,031.96 -> 104,674,521.50
0.07% installer size osx-shippable opt instrumented 104,638,228.12 -> 104,716,564.25

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Nicholas Nethercote [inactive]]

kvark: Does RON ship in Firefox?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1664105

Comment 3

[Dzmitry Malyshau [:kvark]]

Yes. It's used for saving traces in WebRender in WebGPU, which we want to be available in release builds. That allows users to provide us with complete reproductions of the issues.
See:

• https://searchfox.org/mozilla-central/rev/5efefd3ef214ed6d3234ba245c1da3004ead94e0/gfx/webrender_bindings/Cargo.toml#31
• https://searchfox.org/mozilla-central/rev/5efefd3ef214ed6d3234ba245c1da3004ead94e0/gfx/wr/webrender/Cargo.toml#16
• https://searchfox.org/mozilla-central/rev/5efefd3ef214ed6d3234ba245c1da3004ead94e0/gfx/wgpu_bindings/Cargo.toml#21
• https://searchfox.org/mozilla-central/rev/5efefd3ef214ed6d3234ba245c1da3004ead94e0/gfx/wgpu/wgpu-core/Cargo.toml#19

Comment 4

[Nicholas Nethercote [inactive]]

I bet this is due to https://github.com/ron-rs/ron/issues/239.

Comment 5

[Jim Mathies [:jimm]]

Per Dzmitry comment, a worthy trade off.