fuzzing builds are always triggered on "mach try auto" pushes
Categories
(Firefox Build System :: Task Configuration, defect)
Tracking
(Not tracked)
People
(Reporter: marco, Unassigned)
References
(Blocks 1 open bug)
Details
Maybe related to bug 1656465?
|
||
Comment 1•4 years ago
•
|
||
I once looked into why they were scheduled on my push and it was because bugbug was selecting them in the tasks list. Unsure if this is always the case or not.
|
Reporter | |
Comment 2•4 years ago
|
||
I think this is no longer the case, given that we now even have a test ensuring fuzzing builds are not schedulable: https://searchfox.org/mozilla-central/rev/3151f97de27730793c2e298716df760999423f26/taskcluster/test/test_mach_try_auto.py#86-89.
:ahal, am I missing something?
|
|
||
Comment 3•4 years ago
|
||
Probably?
Those tests use a mock bugbug-push-schedules.json and a static parameters.yml. So really the test is only asserting that fuzzing builds don't show up for the specific data used in generation. But since builds don't use bugbug anyway, I'm fairly sure that the test is accurate enough for now.
I'd recommend WORKSFORME.
|
|
||
Comment 4•4 years ago
|
||
Aside, since that test is only asserting builds that presumably shouldn't be affected by optimization too much, it should probably be using the target_task_graph to remove bugbug from the equation. Or maybe it is relying on skip-unless-schedules to remove them? I'm not sure now.
|
|
Reporter | |
Comment 5•4 years ago
|
||
(In reply to Andrew Halberstadt [:ahal] from comment #3)
Those tests use a mock bugbug-push-schedules.json and a static parameters.yml. So really the test is only asserting that fuzzing builds don't show up for the specific data used in generation. But since builds don't use bugbug anyway, I'm fairly sure that the test is accurate enough for now.
They are since https://hg.mozilla.org/mozilla-central/rev/3011872aa773. Fuzzing builds in particular are using skip-unless-expanded though (https://hg.mozilla.org/mozilla-central/rev/7ba9ec4d39f3).
I guess we need to add the fuzzing builds to the mock bugbug-push-schedules.json and see what happens to the test to make sure...
|
|
||
Comment 6•2 years ago
|
||
I believe this was fixed elsewhere.
Description
•