1665623 - Potential deadlock detected in nsHttpTransaction::Restart()

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Kershaw Chang [:kershaw]]

I've accidentally hit the code here and found the error message below.

 0:05.88 pid:8592 ###!!! ERROR: Potential deadlock detected:
 0:05.88 pid:8592 === Cyclical dependency starts at
 0:05.88 pid:8592 --- RecursiveMutex : nsHttpRequestHead.mRecursiveMutex calling context
 0:05.88 pid:8592   [stack trace unavailable]
 0:05.88 pid:8592 --- Next dependency:
 0:05.88 pid:8592 --- Mutex : nsHttp.sLock (currently acquired)
 0:05.88 pid:8592  calling context
 0:05.88 pid:8592   [stack trace unavailable]
 0:05.88 pid:8592 === Cycle completed at
 0:05.88 pid:8592 --- RecursiveMutex : nsHttpRequestHead.mRecursiveMutex calling context
 0:05.88 pid:8592   [stack trace unavailable]
 0:05.88 pid:8592 Deadlock may happen for some other execution
 0:05.88 pid:8592 [8592, Socket Thread] WARNING: Potential deadlock detected:
 0:05.88 pid:8592 Cyclical dependency starts at
 0:05.88 pid:8592 RecursiveMutex : nsHttpRequestHead.mRecursiveMutex
 0:05.88 pid:8592 Next dependency:
 0:05.88 pid:8592 Mutex : nsHttp.sLock (currently acquired)
 0:05.88 pid:8592 Cycle completed at
 0:05.88 pid:8592 RecursiveMutex : nsHttpRequestHead.mRecursiveMutex
 0:05.88 pid:8592 Deadlock may happen for some other execution

Apparently, this is caused by calling mRequestHead->SetHeader when nsHttp::GetLock() is locked.

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 1665623 - Remove the unnessary lock

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/033c559df918
Remove the unnessary lock r=necko-reviewers,valentin

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/033c559df918