1665637 - Remove the 'saved-session' ping

Status: ASSIGNED

(Toolkit :: Telemetry, task, P4)

Description

[Alessio Placitelli [:Dexter]]

Bug 1656910 is happening: should we remove the 'saved-session' from legacy telemetry and simplify the codebase a bit?

Comment 1

[Chris H-C :chutten]

At the present time there's an awful lot of Everything Else to be done, so this gets a position rather far down the list for planned work.

If anyone'd like to tackle this in unplanned time, by all means please do.

Comment 2

[Charlotte Wilson [:cswilson252]]

Looking to start working on this, just wondering if this is being blocked by 1656910 or no?

Comment 3

[Charlotte Wilson [:cswilson252]]

Attachment: Bug 1665637 - Remove the 'saved-session' ping r=#toolkit-telemetry-reviewers!,#fluent-reviewers!

Comment 4

[Chris H-C :chutten]

It is not blocked by bug 1656910, we can remove the client code at our leisure

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/af8005a9bd4d
https://hg.mozilla.org/integration/autoland/rev/21716ba201e5
Remove the 'saved-session' ping r=fluent-reviewers,toolkit-telemetry-reviewers,bolsson,chutten

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/457bd547ee10
https://hg.mozilla.org/integration/autoland/rev/9bede0f9644a
Revert "Bug 1665637 - Remove the 'saved-session' ping r=fluent-reviewers,toolkit-telemetry-reviewers,bolsson,chutten" for causing failures at test_TelemetrySession.js.

Comment 7

[Atila Butkovits]

Backed out for causing failures at test_TelemetrySession.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/9bede0f9644afbb914c1ba6f52b829680ea6d620

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=21716ba201e578819a519722d41c71c168ee0823&selectedTaskRun=cQFIuIS_R62Yur66r2tvLg.0

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=543776832&repo=autoland&task=cQFIuIS_R62Yur66r2tvLg.0&lineNumber=1953

https://treeherder.mozilla.org/logviewer?job_id=543776592&repo=autoland&task=Mvpnr1_xQbuvKDtRfSUEow.0&lineNumber=5978

Comment 8

[Charlotte Wilson [:cswilson252]]

whoops, test still references the anonymous-ping doc that I moved to the obsolete folder. Fixing.

Comment 9

[Charlotte Wilson [:cswilson252]]

Still figuring out the test_TelemetrySession.js timeouts.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f35f0a1b1b47
https://hg.mozilla.org/integration/autoland/rev/c66600fb58ef
Remove the 'saved-session' ping r=fluent-reviewers,toolkit-telemetry-reviewers,bolsson,chutten

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/053734ae1682
https://hg.mozilla.org/integration/autoland/rev/df9c23d6b7d8
Revert "Bug 1665637 - Remove the 'saved-session' ping r=fluent-reviewers,toolkit-telemetry-reviewers,bolsson,chutten" for failures on test_TelemetrySession.

Comment 12

[Cosmin Sabou [:CosminS]]

Backed out for failures on test_TelemetrySession.

Push with failures

Failure log

Backout link

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9d1bc2e4f68a
https://hg.mozilla.org/integration/autoland/rev/8aeee1c5e24c
Remove the 'saved-session' ping r=fluent-reviewers,toolkit-telemetry-reviewers,bolsson,chutten

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/82dd1071342f
https://hg.mozilla.org/integration/autoland/rev/b0b60d6d1cb4
Revert "Bug 1665637 - Remove the 'saved-session' ping r=fluent-reviewers,toolkit-telemetry-reviewers,bolsson,chutten" for causing xpc failures on test_TelemetrySession.js

Comment 15

[Cristina Horotan [:chorotan]]

Backed out for causing xpc failures on test_TelemetrySession.js

Backout link

Push with failures

Failure log

Comment 16

[Charlotte Wilson [:cswilson252]]

Possibly related to test_saveLoadPing()

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f0933883552f
https://hg.mozilla.org/integration/autoland/rev/9f8fd4cfdac4
Remove the 'saved-session' ping r=fluent-reviewers,toolkit-telemetry-reviewers,bolsson,chutten

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/79122b5b73e6
https://hg.mozilla.org/integration/autoland/rev/5d35c8fdd30a
Revert "Bug 1665637 - Remove the 'saved-session' ping r=fluent-reviewers,toolkit-telemetry-reviewers,bolsson,chutten" for causing xpc failures @ test_TelemetrySession.js

Comment 19

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures @ test_TelemetrySession.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/376542f8131f87897534df84ca26e03c00ff575b

Push with failures

Failure log -> TEST-UNEXPECTED-TIMEOUT | toolkit/components/telemetry/tests/unit/test_TelemetrySession.js | Test timed out

Comment 20

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #18)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/79122b5b73e6
https://hg.mozilla.org/integration/autoland/rev/5d35c8fdd30a
Revert "Bug 1665637 - Remove the 'saved-session' ping
r=fluent-reviewers,toolkit-telemetry-reviewers,bolsson,chutten" for causing
xpc failures @ test_TelemetrySession.js

Perfherder has detected a mozperftest performance change from push 5d35c8fdd30a30bd2d09fdd5c55081790aa711da.

No action is required from the author; this comment is provided for informational purposes only.

Improvement	Test	Platform	Options	Absolute values [old vs new]
24%	homeview-startup homeview_startup	android-hw-a55-14-0-aarch64-shippable		1,421.82 ms -> 1,073.74 ms

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.