Closed Bug 1665649 Opened 5 years ago Closed 5 years ago

The paper list is being created twice for the new printing UI on Windows

Categories

(Core :: Printing: Setup, enhancement, P1)

Unspecified
Windows
enhancement

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: bobowen, Assigned: bobowen)

Details

(Whiteboard: [print2020_v82][old-ui-])

Attachments

(1 file)

While looking at the performance of nsPrinterWin::DefaultSettings I realised that because I was using PaperList it was causing the APIs to be called twice, because the caching is only done on the main thread on a Promise.

This leaves the paperName blank instead and looks it up in the front end code.
The paper size is retrieved from the information context instead.
This also changes to using a double literal for converting inches to points for
better precision.

Pushed by bobowencode@gmail.com: https://hg.mozilla.org/integration/autoland/rev/15285ea8cb4a Don't use PaperList on the background thread in nsPrinterWin::DefaultSettings. r=jwatt
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: