Closed Bug 1665713 Opened 1 year ago Closed 1 year ago

move dom/media/tests/mochitest to dom/media/webrtc/tests/mochitests

Categories

(Core :: WebRTC, task, P2)

task

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: mjf, Assigned: mjf)

References

(Regressed 1 open bug)

Details

Attachments

(3 files)

Assignee: nobody → mfroman
Blocks: 1654185
Severity: -- → S3
Priority: -- → P2
Attachment #9176378 - Attachment description: Bug 1665713 - move dom/media/tests/mochitest to dom/media/webrtc/tests/mochitests. r?ng! → Bug 1665713 - pt1 - move dom/media/tests/mochitest to dom/media/webrtc/tests/mochitests. r?ng!

These were originally masked due to an exception in
tools/lint/file-whitespace.html for the directory dom/media/tests, but we
don't need an exception for our new location (dom/media/webrtc/tests/mochitests)
if we fix these 3 files.

2 files had bad line endings (Windows vs Unix):
dom/media/webrtc/tests/mochitests/test_getUserMedia_cubebDisabled.html
dom/media/webrtc/tests/mochitests/test_getUserMedia_cubebDisabledFakeStreams.html

1 file had trailing whitespace:
dom/media/webrtc/tests/mochitests/test_peerConnection_threeUnbundledConnections.html

Depends on D90614

Pushed by mfroman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad03f6f54321
pt1 - move dom/media/tests/mochitest to dom/media/webrtc/tests/mochitests. r=ng
https://hg.mozilla.org/integration/autoland/rev/e926364f5d4f
pt2 - fix reviewbot whitespace issues. r=ng

Thank you, I missed an eslint exception for the moved mochitest directory. I'll get it fixed!

Flags: needinfo?(mfroman)

This was originally excepted under dom/media/tests/** here:
https://searchfox.org/mozilla-central/rev/89d33e1c3b0a57a9377b4815c2f4b58d933b7c32/.eslintrc.js#235

I'm adding the exception for dom/media/webrtc/tests/** for the moved files.

Depends on D90630

Pushed by mfroman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/433d8f92b482
pt1 - move dom/media/tests/mochitest to dom/media/webrtc/tests/mochitests. r=ng
https://hg.mozilla.org/integration/autoland/rev/770d63754715
pt2 - fix reviewbot whitespace issues. r=ng
https://hg.mozilla.org/integration/autoland/rev/296d5facd7bd
pt3 - fix js lint issues resulting from moving mochitest directory. r=ng
See Also: → 1667401

(In reply to Michael Froman [:mjf] from comment #3)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9b493712af6b0712b35aba04e40abbe143a53cb

I just added the media mochitest jobs to my old push and they passed. Let me push the same after my rebase.

Flags: needinfo?(mfroman)

Here is a run based on the error shown in Bug 1667271:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=56a557e52bb54e8d98fac4948066487ed59562e6

I don't see the same issue, so I'm going to rebase and then collapse the changes for the manifest location change into pt 1.

Here are the windows7-32-qr opt/debug media mochitests failing without my changes on central:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7b243056ffc4587bc71ebcc87272b3111a0e604

Here are the same tests failing after my changes in the same way:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=deeb1581c692ebcb42378f0b78d2d5e572a9e3ab&selectedTaskRun=VdAhCjJNTya30uuTHVY5qg.0

Pushed by mfroman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77616d857c66
pt1 - move dom/media/tests/mochitest to dom/media/webrtc/tests/mochitests. r=ng
https://hg.mozilla.org/integration/autoland/rev/4b8694d2c018
pt2 - fix reviewbot whitespace issues. r=ng
https://hg.mozilla.org/integration/autoland/rev/5ba8ebc6b02b
pt3 - fix js lint issues resulting from moving mochitest directory. r=ng
You need to log in before you can comment on or make changes to this bug.