1665713 - move dom/media/tests/mochitest to dom/media/webrtc/tests/mochitests

Status: RESOLVED FIXED

(Core :: WebRTC, task, P2)

Description

[Michael Froman [:mjf]]

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1654185#c6

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1665713 - pt1 - move dom/media/tests/mochitest to dom/media/webrtc/tests/mochitests. r?ng!

Comment 2

[Michael Froman [:mjf]]

Attachment: Bug 1665713 - pt2 - fix reviewbot whitespace issues. r?ng!

These were originally masked due to an exception in
tools/lint/file-whitespace.html for the directory dom/media/tests, but we
don't need an exception for our new location (dom/media/webrtc/tests/mochitests)
if we fix these 3 files.

2 files had bad line endings (Windows vs Unix):
dom/media/webrtc/tests/mochitests/test_getUserMedia_cubebDisabled.html
dom/media/webrtc/tests/mochitests/test_getUserMedia_cubebDisabledFakeStreams.html

1 file had trailing whitespace:
dom/media/webrtc/tests/mochitests/test_peerConnection_threeUnbundledConnections.html

Depends on D90614

Comment 3

[Michael Froman [:mjf]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9b493712af6b0712b35aba04e40abbe143a53cb

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad03f6f54321
pt1 - move dom/media/tests/mochitest to dom/media/webrtc/tests/mochitests. r=ng
https://hg.mozilla.org/integration/autoland/rev/e926364f5d4f
pt2 - fix reviewbot whitespace issues. r=ng

Comment 5

[Razvan Maries]

Backed out for Lint failure.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=O1s4pMIxQ1aO36JYbO5-Yw.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=e926364f5d4f51ae8cf689c22ed88bd4fb046af6

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316629068&repo=autoland&lineNumber=128

Backout: https://hg.mozilla.org/integration/autoland/rev/78293515e3dfa40d2d7c7463a12008b65aa27e47

Comment 6

[Michael Froman [:mjf]]

Thank you, I missed an eslint exception for the moved mochitest directory. I'll get it fixed!

Comment 7

[Michael Froman [:mjf]]

Fixed the eslint exception for the moved directory:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9116f09dfd30e404361f655d805b905e27a1532&selectedTaskRun=as5MiYPTRLe648iJJQnyFA.0

Comment 8

[Michael Froman [:mjf]]

Attachment: Bug 1665713 - pt3 - fix js lint issues resulting from moving mochitest directory. r?ng!

This was originally excepted under dom/media/tests/** here:
https://searchfox.org/mozilla-central/rev/89d33e1c3b0a57a9377b4815c2f4b58d933b7c32/.eslintrc.js#235

I'm adding the exception for dom/media/webrtc/tests/** for the moved files.

Depends on D90630

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/433d8f92b482
pt1 - move dom/media/tests/mochitest to dom/media/webrtc/tests/mochitests. r=ng
https://hg.mozilla.org/integration/autoland/rev/770d63754715
pt2 - fix reviewbot whitespace issues. r=ng
https://hg.mozilla.org/integration/autoland/rev/296d5facd7bd
pt3 - fix js lint issues resulting from moving mochitest directory. r=ng

Comment 10

[Razvan Maries]

Backed out for perma failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=66c2fb744703db4a64a47221d70ef144ccf6e254&searchStr=mda&failure_classification_id=2

Logs:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316653513&repo=autoland&lineNumber=24968
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316655721&repo=autoland&lineNumber=29485

TV failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=BN1pFlcDQjKxWd54zHlY_Q.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=296d5facd7bdb2c66034a35c4659e37bbd9498e5&searchStr=tv

Logs:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316653399&repo=autoland&lineNumber=30212
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316651165&repo=autoland&lineNumber=2401
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316651861&repo=autoland&lineNumber=41957
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316651859&repo=autoland&lineNumber=38238
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316654537&repo=autoland&lineNumber=113039

Backout: https://hg.mozilla.org/integration/autoland/rev/9b1649eb55adb764a3ba72c4ca458dd3f0dae2eb

Comment 11

[Michael Froman [:mjf]]

(In reply to Michael Froman [:mjf] from comment #3)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9b493712af6b0712b35aba04e40abbe143a53cb

I just added the media mochitest jobs to my old push and they passed. Let me push the same after my rebase.

Comment 12

[Michael Froman [:mjf]]

Here is a run based on the error shown in Bug 1667271:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=56a557e52bb54e8d98fac4948066487ed59562e6

I don't see the same issue, so I'm going to rebase and then collapse the changes for the manifest location change into pt 1.

Comment 13

[Michael Froman [:mjf]]

Here are the windows7-32-qr opt/debug media mochitests failing without my changes on central:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7b243056ffc4587bc71ebcc87272b3111a0e604

Here are the same tests failing after my changes in the same way:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=deeb1581c692ebcb42378f0b78d2d5e572a9e3ab&selectedTaskRun=VdAhCjJNTya30uuTHVY5qg.0

Comment 14

[Michael Froman [:mjf]]

fuzzy query: mochitest-media
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3892acce0e0462c0b895a3ac20761fb2ce0cf5a6

Looks reasonable.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77616d857c66
pt1 - move dom/media/tests/mochitest to dom/media/webrtc/tests/mochitests. r=ng
https://hg.mozilla.org/integration/autoland/rev/4b8694d2c018
pt2 - fix reviewbot whitespace issues. r=ng
https://hg.mozilla.org/integration/autoland/rev/5ba8ebc6b02b
pt3 - fix js lint issues resulting from moving mochitest directory. r=ng

Comment 16

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/77616d857c66
https://hg.mozilla.org/mozilla-central/rev/4b8694d2c018
https://hg.mozilla.org/mozilla-central/rev/5ba8ebc6b02b