Closed Bug 1665718 Opened 4 years ago Closed 4 years ago

Clean up element store in parent process when a tab closes

Categories

(Remote Protocol :: Marionette, defect, P3)

defect

Tracking

(Fission Milestone:M7, firefox84 fixed)

RESOLVED FIXED
84 Branch
Fission Milestone M7
Tracking Status
firefox84 --- fixed

People

(Reporter: impossibus, Assigned: impossibus)

References

Details

(Whiteboard: [marionette-fission-mvp], [wptsync upstream])

Attachments

(3 files)

Follow-up from Bug 1654513, where we only clear the element store used by MarionetteFrameParent on DeleteSession.

Whiteboard: [marionette-fission-mvp-reserve] → [marionette-fission-mvp]

Tentatively tracking marionette-fission-mvp bugs for Fission M7 Beta milestone. We would like Marionette tests to work with Fission before we ride the trains to Beta.

Fission Milestone: --- → M7
Assignee: nobody → mjzffr
Status: NEW → ASSIGNED

I haven't been actively working on this; looking at Marionette Actions API instead.

Assignee: mjzffr → nobody
Status: ASSIGNED → NEW
Assignee: nobody → mjzffr
Status: NEW → ASSIGNED
Attachment #9183259 - Attachment description: Bug 1665718 - Clean up element store in parent process when a tab closes → Bug 1665718 - [marionette] Clean up element store in parent process when a tab closes
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3d4ff5339575
[marionette] Clean up element store in parent process when a tab closes r=marionette-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/b40b2f7d66d9
[marionette] Throw NoSuchElementError when we get a null ContentDOMReference r=marionette-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/3dc0597b5281
[wdspec] Test element references after tab switch or close r=webdriver-reviewers,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26489 for changes under testing/web-platform/tests
Whiteboard: [marionette-fission-mvp] → [marionette-fission-mvp], [wptsync upstream]

Backed out for failures on test_store.js

backout: https://hg.mozilla.org/integration/autoland/rev/e48d9e71af4a5a3aa47bc60df0771613a5198b13

push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=3dc0597b528192474693f7883e3175c670d9f2b9&group_state=expanded&test_paths=testing%2Fmarionette%2Ftest%2Funit%2Fxpcshell.ini&selectedTaskRun=aoE0wi_hSIehpNxVUOuWHQ.0

failure log: https://treeherder.mozilla.org/logviewer?job_id=321485302&repo=autoland&lineNumber=2701

[task 2020-11-11T19:27:50.249Z] 19:27:50 INFO - TEST-START | testing/marionette/test/unit/test_store.js
[task 2020-11-11T19:27:50.447Z] 19:27:50 WARNING - TEST-UNEXPECTED-FAIL | testing/marionette/test/unit/test_store.js | xpcshell return code: 0
[task 2020-11-11T19:27:50.447Z] 19:27:50 INFO - TEST-INFO took 189ms
[task 2020-11-11T19:27:50.447Z] 19:27:50 INFO - >>>>>>>
[task 2020-11-11T19:27:50.447Z] 19:27:50 INFO - PID 10711 | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2020-11-11T19:27:50.447Z] 19:27:50 INFO - PID 10711 | [10711, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:2949
[task 2020-11-11T19:27:50.447Z] 19:27:50 INFO - TypeError: can't access property "namespaceURI", node.ownerDocument.documentElement is undefined at chrome://marionette/content/element.js:1467
[task 2020-11-11T19:27:50.447Z] 19:27:50 INFO - element.isInXULDocument@chrome://marionette/content/element.js:1467:1
[task 2020-11-11T19:27:50.447Z] 19:27:50 INFO - from@chrome://marionette/content/element.js:1606:19
[task 2020-11-11T19:27:50.447Z] 19:27:50 INFO - @/builds/worker/workspace/build/tests/xpcshell/tests/testing/marionette/test/unit/test_store.js:76:29
[task 2020-11-11T19:27:50.447Z] 19:27:50 INFO - load_file@/builds/worker/workspace/build/tests/xpcshell/head.js:711:11
[task 2020-11-11T19:27:50.447Z] 19:27:50 INFO - _load_files@/builds/worker/workspace/build/tests/xpcshell/head.js:728:10
[task 2020-11-11T19:27:50.447Z] 19:27:50 INFO - _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:540:14
[task 2020-11-11T19:27:50.447Z] 19:27:50 INFO - @-e:1:1
[task 2020-11-11T19:27:50.447Z] 19:27:50 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2020-11-11T19:27:50.447Z] 19:27:50 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2020-11-11T19:27:50.447Z] 19:27:50 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2020-11-11T19:27:50.447Z] 19:27:50 INFO - running event loop
[task 2020-11-11T19:27:50.447Z] 19:27:50 INFO - PID 10711 | [10711, Main Thread] WARNING: Could not get the program name for a cubeb stream.: 'NS_SUCCEEDED(rv)', file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp:380
[task 2020-11-11T19:27:50.447Z] 19:27:50 INFO - (xpcshell/head.js) | test run_next_test 0 finished (1)
[task 2020-11-11T19:27:50.447Z] 19:27:50 INFO - exiting test

Flags: needinfo?(mjzffr)
Upstream PR was closed without merging

Ahhh, my bad, I never checked this test after rebased onto the recent changes in element.isInXULDocument.

Pushed by mjzffr@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f27f6a8cb86c
[marionette] Clean up element store in parent process when a tab closes r=marionette-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/adf48383eccb
[marionette] Throw NoSuchElementError when we get a null ContentDOMReference r=marionette-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/d5ef9ca74956
[wdspec] Test element references after tab switch or close r=webdriver-reviewers,whimboo
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Flags: needinfo?(mjzffr)
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: