1665889 - Perma [tier2] Mingw /builds/worker/checkouts/gecko/dom/media/webrtc/MediaEngineWebRTC.h:10:10: fatal error: 'CamerasChild.h' file not found

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=316059927&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/VjpF0QotSYeRhjTQnjRAnA/runs/0/artifacts/public/logs/live_backing.log

---

" INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/a11y/DocAccessible.h:11:
[task 2020-09-18T10:10:30.040Z] 10:10:30  WARNING -  /builds/worker/workspace/obj-build/dist/include/mozilla/a11y/HyperTextAccessibleWrap.h:38:20: warning: 'HandleAccEvent' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
[task 2020-09-18T10:10:30.040Z] 10:10:30     INFO -    virtual nsresult HandleAccEvent(AccEvent* aEvent);
[task 2020-09-18T10:10:30.040Z] 10:10:30     INFO -                     ^
[task 2020-09-18T10:10:30.040Z] 10:10:30     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/a11y/AccessibleWrap.h:156:20: note: overridden virtual function is here
[task 2020-09-18T10:10:30.040Z] 10:10:30     INFO -    virtual nsresult HandleAccEvent(AccEvent* aEvent) override;
[task 2020-09-18T10:10:30.040Z] 10:10:30     INFO -                     ^
[task 2020-09-18T10:10:30.040Z] 10:10:30     INFO -  2 warnings generated.
...
INFO -  In file included from Unified_cpp_dom_media_gtest0.cpp:92:
[task 2020-09-18T10:10:52.462Z] 10:10:52     INFO -  In file included from /builds/worker/checkouts/gecko/dom/media/gtest/TestAudioTrackGraph.cpp:13:
[task 2020-09-18T10:10:52.462Z] 10:10:52     INFO -  In file included from /builds/worker/checkouts/gecko/dom/media/webrtc/MediaEngineWebRTCAudio.h:12:
[task 2020-09-18T10:10:52.462Z] 10:10:52     INFO -  /builds/worker/checkouts/gecko/dom/media/webrtc/MediaEngineWebRTC.h:10:10: fatal error: 'CamerasChild.h' file not found
[task 2020-09-18T10:10:52.462Z] 10:10:52     INFO -  #include "CamerasChild.h"
[task 2020-09-18T10:10:52.462Z] 10:10:52     INFO -           ^~~~~~~~~~~~~~~~
[task 2020-09-18T10:10:52.462Z] 10:10:52     INFO -  1 error generated.
[task 2020-09-18T10:10:52.462Z] 10:10:52    ERROR -  make[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:725: Unified_cpp_dom_media_gtest0.o] Error 1
[task 2020-09-18T10:10:52.462Z] 10:10:52     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/media/gtest'
[task 2020-09-18T10:10:52.463Z] 10:10:52    ERROR -  make[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: dom/media/gtest/target-objects] Error 2
[task 2020-09-18T10:10:52.463Z] 10:10:52     INFO -  make[3]: *** Waiting for unfinished jobs....
[task 2020-09-18T10:10:52.465Z] 10:10:52     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/dom/media/ipc'
[task 2020-09-18T10:10:52.465Z] 10:10:52     INFO -  dom/media/ipc/RDDChild.o
[task 2020-09-18T10:10:52.465Z] 10:10:52     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/media/ipc'
[task 2020-09-18T10:10:52.628Z] 10:10:52     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/dom/media/gtest/mp4_demuxer'
[task 2020-09-18T10:10:52.628Z] 10:10:52     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/i686-w64-mingw32-clang++ -std=gnu++17 -o TestInterval.o -c "```

Comment 1

[Sandor Molnar[:smolnar]]

Dan, could you look at this? Seems to be caused by bug 1653219

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1653219

Comment 3

[Dan Minor [:dminor]]

Hi, Bug 1653219 landed on August 11th, but this only started failing yesterday, is it really possible this is the first time we've run this build since the middle of August?

Comment 4

[Dan Minor [:dminor]]

Bug 1656438 landed recently and seems to be making changes to TestAudioTrackGraph.cpp, Andreas, could you please have a look?

Comment 5

[Sandor Molnar[:smolnar]]

These builds run daily. I misread and thought your patch could've caused it but that can't be, sorry.

Comment 6

[Dan Minor [:dminor]]

(In reply to Sandor Molnar from comment #5)

These builds run daily. I misread and though your patch could've caused it but that can't be, sorry

No problem, thank you for double checking.

Comment 7

[Tom Ritter [:tjr]]

This is probably not a MinGW failure, and it's probably a --disable-webrtc failure; because MinGW is the only build that sets that flag.

Comment 8

[Intermittent Failures Robot]

24 failures in 3760 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 24

Platform breakdown:

• windows-mingw32: 24

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1665889&startday=2020-09-14&endday=2020-09-20&tree=all

Comment 9

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1665889 - Hide AudioInputProcessing include behind MOZ_WEBRTC. r?padenot

This has busted the MingW build, where webrtc is not supported.
AudioInputProcessing relies on upstream webrtc for audio processing: aec, etc.

Comment 11

[Dan Horák]

I confirm the attached patch fixes the issue for me (Linux/s390x without WebRTC)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ceb47d667219
Hide AudioInputProcessing include behind MOZ_WEBRTC. r=padenot

Comment 13

[Intermittent Failures Robot]

16 failures in 738 pushes (0.022 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 16

Platform breakdown:

• windows-mingw32: 16

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1665889&startday=2020-09-22&endday=2020-09-22&tree=all

Comment 14

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ceb47d667219

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 16

[Andreas Pehrson [:pehrsons]]

Comment on attachment 9176862 [details]
Bug 1665889 - Hide AudioInputProcessing include behind MOZ_WEBRTC. r?padenot

Beta/Release Uplift Approval Request

• User impact if declined: Builds are busted when built without webrtc support (--disable-webrtc). Platforms that the webrtc.org library doesn't support require this flag and thus are unconditionally busted.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adds a few compile-time #ifdef in a gtest to make the compiler happy. No logical changes and no changes in shipped code.
• String changes made/needed:

Comment 17

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9176862 [details]
Bug 1665889 - Hide AudioInputProcessing include behind MOZ_WEBRTC. r?padenot

tier2 build fix, approved for 82.0b4

Comment 18

[Julien Cristau [:jcristau] (back August 18)]

https://hg.mozilla.org/releases/mozilla-beta/rev/1f4f3aea1095

Comment 19

[Intermittent Failures Robot]

24 failures in 4019 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

This is the #46 most frequent failure this week.

Repository breakdown:

• mozilla-central: 24

Platform breakdown:

• windows-mingw32: 24

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1665889&startday=2020-09-21&endday=2020-09-27&tree=all