Closed Bug 1665927 Opened 3 months ago Closed 3 months ago

Enable PackingStrategy::LowBitTagIsError also for non-pointer types

Categories

(Core :: MFBT, task)

task

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: sg, Assigned: sg)

References

Details

Attachments

(1 file)

In particular, enable it for empty types.

Also, the size of Result can be smaller than a pointer if both the value and error type are smaller (e.g. both empty).

Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1467e76399e8
Use free LSB optimization for empty types with mozilla::Result. r=emilio
Blocks: 1666200

Reproduced and fixed the build bustage with gcc.

Flags: needinfo?(sgiesecke)
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/353266aee10d
Use free LSB optimization for empty types with mozilla::Result. r=emilio
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
Regressions: 1666422
You need to log in before you can comment on or make changes to this bug.