Closed
Bug 1665955
Opened 4 years ago
Closed 4 years ago
Reduce dependencies on nsIScrollableFrame.h
Categories
(Core :: Layout: Scrolling and Overflow, task)
Core
Layout: Scrolling and Overflow
Tracking
()
RESOLVED
FIXED
82 Branch
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
Details
Attachments
(1 file)
Touching this header causes a lot of stuff to get rebuilt, I think mostly because Element.h pulls it in. Breaking that dependency doesn't look hard.
|
Assignee | |
Comment 1•4 years ago
|
||
Built locally on Linux, but let's see if unified builds get the last laugh.
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Comment 3•4 years ago
|
||
Changes to nsIScrollableFrame.h cause the world to rebuild which I find annoying.
This removes the inclusion into Element.h which is responsible for the
world-rebuilding and is relatively easy to eliminate. A bunch of usages of
nsIScrollableFrame get moved from .h files into .cpp files and I include the
header into .cpp files as needed.
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cfb76fbd90bb Stop including nsIScrollableFrame.h from Element.h. r=emilio
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•