1665991 - Stop unnecessarily repainting default buttons and progress bars

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Markus Stange [:mstange]]

We have code which triggers repaints for "default buttons" in dialogs, and for progress bars which aren't indeterminate. That's because on 10.9 and below, the native appearance for those widgets was animated: default buttons had a blue pulse, and progress bars had a blue flow animation.
Now that we no longer support 10.9, we can stop triggering these repaints. Indeterminate progress bars still animate.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1665991 - Stop unnecessarily repainting default buttons and progress bars. r=spohl

On 10.9 and below, the native appearance for those widgets was animated: default buttons had a blue pulse, and progress bars had a blue flow animation.
Now that we no longer support 10.9, we can stop triggering these repaints. Indeterminate progress bars still animate.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72c1f7fbf81b
Stop unnecessarily repainting default buttons and progress bars. r=spohl

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/72c1f7fbf81b