1666030 - Mingw build failure /builds/worker/checkouts/gecko/mozglue/misc/EarlyBlankWindow.cpp:98:10: error: use of undeclared identifier 'floor'

Status: RESOLVED FIXED

(Core :: mozglue, defect)

Description

[(Away)]

This comes up on my clang-trunk builds, not sure why it isn't happening on m-c:

/builds/worker/checkouts/gecko/mozglue/misc/EarlyBlankWindow.cpp:98:10: error: use of undeclared identifier 'floor'
Logviewer
make[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:724: EarlyBlankWindow.o] Error 1 

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316113542&repo=ash&lineNumber=4320

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1656526

Comment 3

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1666030 - Fix floor missing on some builds r?dmajor

Depends on D91004

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7413cfd05f7b
Fix floor missing on some builds r=dmajor

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7413cfd05f7b

Comment 6

[Ryan VanderMeulen (PTO, back 6-April)]

Please nominate this for Beta approval when you get a chance.

Comment 7

[Alex Thayer [:alexical] (she/her)]

Comment on attachment 9177644 [details]
Bug 1666030 - Fix floor missing on some builds r?dmajor

Beta/Release Uplift Approval Request

• User impact if declined: Some builds of mozilla-beta may fail to compile.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It should (barring exceptionally strange circumstances) only affect whether we can or cannot build mozilla-beta successfully.
• String changes made/needed: None

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9177644 [details]
Bug 1666030 - Fix floor missing on some builds r?dmajor

build fix, approved for 82.0b4

Comment 9

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f8c56d611c35

Comment 10

[(Away)]

I temporarily hacked around the other problems in clang-12 builds, and confirmed that the floor piece at least is fixed. Thanks!