1666032 - ensure_java() throws error if $JDK/bin/java is not symlinked to $JDK/jre/bin/java

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect)

Description

[Mitchell Hentges [:mhentges] 🦀]

As reported by :bc, not all linux distros are consistent on how they manage having two paths to java ($JDK/bin/java and $JDK/jre/bin/java).
On debian, it's solved by having a symlink between the two.
On fedora, the binary is duplicated and exists in both spots.

Right now, on Fedora, the "java_version == jarsigner_version" check is failing.

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1666032: ensure java from PATH == java from JDK_BIN_DIR

In the build process, there's two ways that java is used:

• From the path
• From the java-bin-path specified in the mozconfig

Before, to assert that both "java" usages would be consistent, the
implementation assumed that there was only a single "java" binary
per-JDK-version, and all duplicate "binaries" were symlinks to the
original.

However, in Fedora, it has two identical full binaries: one in
$JDK/bin, and one in $JDK/jre/bin. The symlink theory was incorrect.

So instead, we can assert that both "java" usages are consistent
by checking their versions and asserting that they are equivalent.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0db57c7f9f0
ensure java from PATH == java from JDK_BIN_DIR r=rstewart

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/c0db57c7f9f0

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1663837

Comment 5

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dee729abab81