Warp: Inline getters and setters
Categories
(Core :: JavaScript Engine: JIT, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: iain, Assigned: iain)
References
(Blocks 1 open bug)
Details
Attachments
(8 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
This is one of the final missing pieces to reach inlining parity with Ion.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D90762
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D90763
|
|
Assignee | |
Comment 4•4 years ago
|
||
Shuffling some code around in preparation for inlining getters and setters.
- Unified the two versions of TranspileCacheIRToMIR so we can pass both a CallInfo and an input vector, and added a helper for calls on the WarpBuilder side.
- Moved transpilation out of buildInlinedCall so that it can also be called by getters.
Depends on D90764
|
|
Assignee | |
Comment 5•4 years ago
|
||
Depends on D90765
|
|
Assignee | |
Comment 6•4 years ago
|
||
Parallel to the patch for CallInlinedGetter
Depends on D90766
|
|
Assignee | |
Comment 7•4 years ago
|
||
Depends on D90767
|
|
Assignee | |
Comment 8•4 years ago
|
||
Depends on D90768
|
||
Updated•4 years ago
|
Pushed by iireland@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d2e260b86865 Add CallInlinedGetterResult r=jandem https://hg.mozilla.org/integration/autoland/rev/7d1cffdbde56 Trial-inline getters r=jandem https://hg.mozilla.org/integration/autoland/rev/9f2bec2605f3 Create snapshots for getters r=jandem https://hg.mozilla.org/integration/autoland/rev/9ac494197563 Refactor TranspileCacheIRToMIR interface r=jandem https://hg.mozilla.org/integration/autoland/rev/694535a6b9b1 Inline getters in WarpBuilder r=jandem https://hg.mozilla.org/integration/autoland/rev/a114463147c8 Add CallInlinedSetter r=jandem https://hg.mozilla.org/integration/autoland/rev/18aebdd4126c Trial-inline setters r=jandem https://hg.mozilla.org/integration/autoland/rev/3d988bf57830 Inline setters in WarpBuilder r=jandem
|
||
Comment 10•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d2e260b86865
https://hg.mozilla.org/mozilla-central/rev/7d1cffdbde56
https://hg.mozilla.org/mozilla-central/rev/9f2bec2605f3
https://hg.mozilla.org/mozilla-central/rev/9ac494197563
https://hg.mozilla.org/mozilla-central/rev/694535a6b9b1
https://hg.mozilla.org/mozilla-central/rev/a114463147c8
https://hg.mozilla.org/mozilla-central/rev/18aebdd4126c
https://hg.mozilla.org/mozilla-central/rev/3d988bf57830
Description
•