1666045 - Significant memory leak with Grammarly addon, browser becomes unresponsive.

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P2)

Description

[Kevin Jacobs [:kjacobs]]

Attachment: x9tgjbk.png

Noticed in Nightly 82, the issue does not occur in 81.

STR:

1. Load the Grammarly addon (you shouldn't need to sign up or sign in, just click activate).
2. Open an MDN page in Edit mode and try to right-click a link and edit it.
3. The pop-up takes a while to appear and memory usage climbs.

After a few seconds, the browser slows and becomes unresponsive. Reproduces on Mac and Windows. The attached screenshot was taken with a brand new profile.

Comment 1

[Kevin Jacobs [:kjacobs]]

Nightly profile: https://share.firefox.dev/2FIbMxV (can't run if for more than a few seconds, else the capture seems to time out and hang).
Beta profile: https://share.firefox.dev/3hJwrP2

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Is there any chance you could run mozregression to see what broke this?

Comment 3

[Kevin Jacobs [:kjacobs]]

mozregression points to https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=1e2a698cb1870ac8fc161f1e0c23111d071384c1, so I'm not sure why the problem doesn't show up in Beta (81 with Build ID 20200917005511).

However, in Nightly, if I turn tracking protection to "Custom" with all options unchecked and restart the browser, it works as expected (~700MB of memory used by Firefox). With tracking protection set to "Standard" or "Strict" the problem occurs (memory use quickly jumps to ~1.4GB and continues to grow).

Comment 4

[Timea Cernea [:tbabos][inactive]]

Setting up the flags based on when Bug 1652244 was landed.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

(In reply to Kevin Jacobs [:kjacobs] from comment #3)

so I'm not sure why the problem doesn't show up in Beta (81 with Build ID 20200917005511).

dFPI is Nightly-only (see the network.cookie.cookieBehavior pref).

Comment 6

[Dimi Lee [:dimi]]

we have found a solution for this bug, but it requires the patch in Bug 1663192

Comment 7

[Dimi Lee [:dimi]]

Attachment: Bug 1666045 - Use principal to do the third-party check when the page is a about page r=timhuang

Comment 8

[Dimi Lee [:dimi]]

Attachment: Bug 1666045 - Test case to verify whether an about page in iframe has access to cookie r=timhuang

Depends on D91561

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1031c6d4c03
Use principal to do the third-party check when the page is a about page r=timhuang
https://hg.mozilla.org/integration/autoland/rev/d16260bd4230
Test case to verify whether an about page in iframe has access to cookie r=timhuang

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a1031c6d4c03
https://hg.mozilla.org/mozilla-central/rev/d16260bd4230