1666064 - [Windows 7] Set Firefox as default browser also sets it as default PDF viewer and does not confirm despite the use of ellipsis on the button

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect, P3)

Description

[fireattack [:fireattack]]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.102 Safari/537.36

Steps to reproduce:

Click "Make default..."

Actual results:

It not only changes Firefox as my default web browser, it also overrides my default PDF viewer (Adobe Acrobat).

Expected results:

It should only change the default for web browsing, not PDF viewing.

Also, the button for this action is "Make default...", with three dots, but it directly changes your default. This violates the convention that if a button has "...", it means it should open an dialog instead of making change directly.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[:Gijs (he/him)]

I'm fairly sure that the PDF thing is deliberate - Nick, can you comment on how this works?

As for the ellipsis, it's because on Windows 10, we cannot change the defaults ourselves and will open a Windows settings dialog. We haven't come up with separate labels to use on Windows 7 and Windows 10 just to remove the ellipsis...

Comment 3

[fireattack [:fireattack]]

Just tried it on Win 10, AFAIK, Windows settings' "web browser" option will only change the web browser, not PDF viewer.

Is there a reason why it does so on Win7, if it's deliberate?

Comment 4

[Nick Alexander :nalexander [he/him]]

(In reply to fireattack from comment #3)

Just tried it on Win 10, AFAIK, Windows settings' "web browser" option will only change the web browser, not PDF viewer.

Thanks for testing this.

Is there a reason why it does so on Win7, if it's deliberate?

It's not deliberate, AFAIK.

I think this is probably fallout from Bug 1506416, which made it possible to set Firefox as the default PDF viewer. But it looks like on Windows 7 we go through the same code path as Bug 1652412, which makes "Set as Default" set Firefox as the default PDF viewer as well, which isn't deliberate.

My guess is that addressing Bug 1652412 will fix this issue; I will take that ticket.

Comment 5

[Nick Alexander :nalexander [he/him]]

I believe this to have been closed by Bug 1652412.