1666181 - Crash in [@ mozilla::fontlist::FontList::SearchForLocalFace]

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

5 crashes so far (on 4+ devices), all on Windows 10 with 82.0a1 Nightly. First crash with build ID 20200908215255.

Crash report: https://crash-stats.mozilla.org/report/index/5d36be14-9e23-450c-a971-4f74a0200909

Top 10 frames of crashing thread:

0 xul.dll mozilla::fontlist::FontList::SearchForLocalFace gfx/thebes/SharedFontList.cpp:994
1 xul.dll gfxPlatformFontList::LookupInSharedFaceNameList gfx/thebes/gfxPlatformFontList.cpp:761
2 xul.dll gfxUserFontEntry::DoLoadNextSrc gfx/thebes/gfxUserFontSet.cpp:402
3 xul.dll gfxFontGroup::GetFirstValidFont gfx/thebes/gfxTextRun.cpp:2264
4 xul.dll Gecko_GetFontMetrics layout/style/GeckoBindings.cpp:1453
5 xul.dll style::gecko::wrapper::{{impl}}::query servo/components/style/gecko/wrapper.rs:984
6 xul.dll style::values::specified::length::FontRelativeLength::to_computed_value servo/components/style/values/specified/length.rs:137
7 xul.dll style::values::computed::length::{{impl}}::to_computed_value servo/components/style/values/computed/length.rs:36
8 xul.dll style::properties::longhands::margin_right::cascade_property x86_64-pc-windows-msvc/release/build/style-fef97261d93c2a8d/out/longhands/margin.rs:217
9 xul.dll style::properties::cascade::Cascade::apply_properties<style::properties::cascade::LateProperties, core::iter::adapters::Cloned<core::slice::Iter< servo/components/style/properties/cascade.rs:620

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1666181 - Add missing null-check in FontList::SearchForLocalFace to avoid possible crash. r=jwatt

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bab3bcfe53d
Add missing null-check in FontList::SearchForLocalFace to avoid possible crash. r=jwatt

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/2bab3bcfe53d

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jfkthame, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 5

[Jonathan Kew [:jfkthame]]

This is preffed-off on beta, so probably not worth uplifting.