1666214 - Parallel shutdown of quota clients

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1666214 - Perform shutdown of all quota clients in parallel. r=#dom-workers-and-storage

Depends on D94741

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1666214 - Move shutdown timeout handling to QuotaManager. r=#dom-workers-and-storage

Instead of having a separate timer for each quota client, we can use a single
timer in the QuotaManager for handling timeouts of all quota clients. The
original shutdown timeout of the quota manager itself can now be removed,
as AbortOperations is already called through InitiateShutdownWorkThreads on
each quota client.

This also moves MaybeRecordShutdownStep to the QuotaManager, which allows
easier access through the singleton instance returned by QuotaManager::GetRef.

Depends on D96082

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d45a42bcf51d
Perform shutdown of all quota clients in parallel. r=dom-workers-and-storage-reviewers,janv

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/d45a42bcf51d

Comment 6

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1666214 - Don't crash if the shutdown already completed when the shutdown timeout event is processed. r=#dom-workers-and-storage

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2fee9228390
Don't crash if the shutdown already completed when the shutdown timeout event is processed. r=dom-workers-and-storage-reviewers,janv

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e2fee9228390

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/547a95c0bb90
Move shutdown timeout handling to QuotaManager. r=dom-workers-and-storage-reviewers,janv

Comment 11

[Alexandru Michis [:malexandru]]

Backed out changeset 547a95c0bb90 (Bug 1666214) for causing talos failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/3757f840ee0108105420575c8ccba91d738e3e94

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&searchStr=talos&fromchange=c286f6117a4519bee68f067c6603381f0a100217&tochange=3757f840ee0108105420575c8ccba91d738e3e94&selectedTaskRun=DPOBTlUOQ2WD7wFVQrEMOQ.0

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=324073996&repo=autoland&lineNumber=2769
• https://treeherder.mozilla.org/logviewer?job_id=324064037&repo=autoland&lineNumber=1313

Comment 12

[Simon Giesecke [:sg] [he/him]]

I have a bit of a hard time seeing how these failures could be connected to the changed made in the patch, but I will give it a closer look tomorrow.

Comment 13

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/7765d979d044
Backed out changeset 547a95c0bb90 for causing talos failures.

Comment 14

[Simon Giesecke [:sg] [he/him]]

Moving over the backed out patch to Bug 1681670, and closing this.

Comment 15

[Phabricator Automation]

Comment on attachment 9189995 [details]
Bug 1666214 - Move shutdown timeout handling to QuotaManager. r=#dom-workers-and-storage

Revision D98073 was moved to bug 1681670. Setting attachment 9189995 [details] to obsolete.