1666307 - clang++: .../build/clang-plugin/MustReturnFromCallerChecker.cpp:50: virtual void MustReturnFromCallerChecker::check(const MatchFinder::MatchResult &): Assertion `Block && "This statement should be within the CFG!"' failed.

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Simon Giesecke [:sg] [he/him]]

I need to figure this out in detail, but it seems to be caused by code like this (where aRv is a ErrorResult*):

      IDB_TRY_VAR(
          auto item, MakeIndexUpdateInfo(aIndexID, value, aLocale), QM_VOID,
          [aRv](const auto& tryResult) { aRv->Throw(tryResult.inspectErr()); });

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1666307 - Turn assertion failure into an early return for now. r=andi

Depends on D90878

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10a6a89276e7
Turn assertion failure into an early return for now. r=andi

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/10a6a89276e7

Comment 4

[Simon Giesecke [:sg] [he/him]]

Andi, do you think there should be some more investigation on why the statement is not in the CFG? If yes, should this be done on this bug, or should we close this bug and file a new one?

Comment 5

[Andi [:andi]]

I don't think the logic of building the CFG is correct or at least we are missing something when we match things by not correlating containing-lambda/containing-func with call.
We should open another bug for this to get resolved.

Comment 6

[Simon Giesecke [:sg] [he/him]]

I filed Bug 1698027 now for having that fixed, but closing this one as the assertion failure is fixed.