Closed
Bug 1666374
Opened 4 years ago
Closed 4 years ago
Figure out if we should stop trying to support inactive/cached windows in before unload prompt
Categories
(Toolkit Graveyard :: Notifications and Alerts, task)
Toolkit Graveyard
Notifications and Alerts
Tracking
(firefox84 fixed)
RESOLVED
FIXED
84 Branch
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: kmag, Assigned: pbz)
References
Details
Attachments
(1 file)
The code explicitly allows for it, and tries to use window-modal rather than tab-modal prompts, but we really probably don't want to allow it at all.
|
||
Comment 1•4 years ago
|
||
Paul, do you perhaps have cycles to take a look here?
Looking at https://hg.mozilla.org/mozilla-central/file/tip/browser/components/prompts/PromptCollection.jsm#l98 , it would seem we could just not prompt if the ancestors of the BC are not current.
Flags: needinfo?(pbz)
|
Assignee | |
Comment 2•4 years ago
|
||
Sure. Thanks!
Assignee: nobody → pbz
Status: NEW → ASSIGNED
Flags: needinfo?(pbz)
|
|
Assignee | |
Comment 3•4 years ago
|
||
Pushed by pzuhlcke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3e11fedf9543
Skip beforeunload prompt for inactive/cached windows. r=Gijs,kmag
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
|
||
Updated•1 year ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•