1666404 - Invalidate depth attachments immediately after rendering and before binding next FBO

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Jamie Nicol [:jnicol]]

On Mali and other tiled architectures this will allow the driver to skip writing out the depth data to memory, saving memory bandwidth.

Currently we only ever invalidate both color and depth attachments at the same time in TextureResolver::return_to_pool(). This is too late to avoid writing out the depth data to memory, and I don't think is used for picture cache targets at all.

Comment 1

[Jamie Nicol [:jnicol]]

Attachment: Bug 1666404 - Invalidate depth attachments at end of render passes. r?gw

This must be done before the draw framebuffer is unbound, to allow
tiled GPUs to avoid writing the contents back to memory.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e37018e0a4d3
Invalidate depth attachments at end of render passes. r=gw

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e37018e0a4d3