1666417 - Enable Warp in Nightly

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P2)

Description

[Jan de Mooij [:jandem]]

We should flip the Warp browser pref on Nightly. After that we can change the default for the shell and turn the SM(warp) job into a SM(no-warp) job.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1666417 part 1 - Make Warp pref work on non-Nightly. r?iain!

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1666417 part 2 - Remove JitOptions.typeInference. r?iain!

At this point it's equivalent to Warp being disabled.

Depends on D90956

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1666417 part 3 - Enable Warp in the browser. r?iain!

Also bumps the threshold to 1500 to match DefaultJitOptions::setWarpEnabled.

Changing the JS shell default is more tricky and will be done separately if this
sticks.

Depends on D90957

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a02a9c359285
part 1 - Make Warp pref work on non-Nightly. r=iain
https://hg.mozilla.org/integration/autoland/rev/98e2eaed1e4b
part 2 - Remove JitOptions.typeInference. r=iain

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91b890df65c5
part 3 - Enable Warp in the browser. r=iain

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a02a9c359285
https://hg.mozilla.org/mozilla-central/rev/98e2eaed1e4b

Comment 7

[Jan de Mooij [:jandem]]

Heads up for perf sheriffs: part 3 in this bug is going to trigger a lot of perf alerts. We're expecting mostly improvements and some regressions, but would be good to know the details.

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/91b890df65c5

Comment 9

[Jan de Mooij [:jandem]]

Attachment: Bug 1666417 part 4 - Add a temporary SM(nowarp) job. r?sfink!,jmaher!

Until we remove IonBuilder/TI (October or November if all goes well) we need to
make sure we don't break it when we enable Warp by default in the JS shell too.
This patch adds a temporary no-warp job based on the plaindebug variant that runs
shell tests with --no-warp.

The next step is enabling Warp by default in the JS shell + removing the SM(warp) job.

Comment 10

[Florin Strugariu [:Bebe]]

== Change summary for alert #27074 (as of Mon, 28 Sep 2020 06:29:14 GMT) ==

Improvements:

11% raptor-tp6-docs-firefox-cold dcf windows10-64-shippable-qr opt webrender 1,282.25 -> 1,144.58
9% raptor-tp6-docs-firefox-cold windows10-64-shippable-qr opt webrender 842.35 -> 770.33
7% raptor-tp6-netflix-firefox-cold loadtime windows7-32-shippable opt 919.25 -> 858.58
7% raptor-tp6-docs-firefox-cold windows10-64-shippable-qr opt webrender 844.66 -> 789.11
4% raptor-tp6-office-firefox-cold loadtime windows7-32-shippable opt 2,435.75 -> 2,334.92

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=27074

See Bug 1667797

Comment 11

[Florin Strugariu [:Bebe]]

== Change summary for alert #27029 (as of Thu, 24 Sep 2020 04:45:21 GMT) ==

Improvements:

26% youtube-watch fcp android-hw-p2-8-0-android-aarch64-shippable opt warm 696.83 -> 518.50
20% youtube-watch ContentfulSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 668.96 -> 535.00
16% imdb loadtime android-hw-g5-7-0-arm7-api-16-shippable opt warm 5,421.21 -> 4,555.92
15% imdb loadtime android-hw-p2-8-0-android-aarch64-shippable opt warm 2,019.54 -> 1,720.71
15% reddit ContentfulSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,988.92 -> 2,554.00
14% instagram LastVisualChange android-hw-p2-8-0-android-aarch64-shippable opt warm 1,962.75 -> 1,687.42
14% imdb loadtime android-hw-g5-7-0-arm7-api-16-shippable opt cold 6,389.56 -> 5,522.29
13% reddit loadtime android-hw-g5-7-0-arm7-api-16-shippable opt cold 5,395.92 -> 4,700.04
13% reddit SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 4,413.75 -> 3,855.50
13% cnn loadtime android-hw-p2-8-0-android-aarch64-shippable opt warm 1,741.83 -> 1,523.96
12% reddit ContentfulSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 1,338.33 -> 1,171.42
12% reddit SpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 2,144.17 -> 1,879.92
12% microsoft-support ContentfulSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 1,173.58 -> 1,029.83
12% microsoft-support FirstVisualChange android-hw-p2-8-0-android-aarch64-shippable opt warm 1,173.58 -> 1,029.83
12% microsoft-support LastVisualChange android-hw-p2-8-0-android-aarch64-shippable opt warm 1,173.58 -> 1,029.83
12% microsoft-support PerceptualSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 1,173.58 -> 1,029.83
12% microsoft-support SpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 1,173.58 -> 1,029.83
12% microsoft-support fcp android-hw-p2-8-0-android-aarch64-shippable opt warm 1,160.04 -> 1,019.21
12% cnn ContentfulSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 1,912.42 -> 1,683.25
12% reddit loadtime android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,342.58 -> 2,062.21
12% cnn fcp android-hw-p2-8-0-android-aarch64-shippable opt warm 1,809.58 -> 1,594.25
12% cnn FirstVisualChange android-hw-p2-8-0-android-aarch64-shippable opt warm 1,819.25 -> 1,605.83
12% reddit LastVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 5,429.08 -> 4,792.42
12% microsoft-support fcp android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,402.04 -> 2,120.58
12% microsoft-support ContentfulSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,415.42 -> 2,132.67
12% microsoft-support FirstVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,415.42 -> 2,132.67
12% microsoft-support LastVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,415.42 -> 2,132.67
12% microsoft-support PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,415.42 -> 2,132.67
12% microsoft-support SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,415.42 -> 2,132.67
12% instagram loadtime android-hw-p2-8-0-android-aarch64-shippable opt warm 1,147.75 -> 1,013.71
12% facebook loadtime android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,699.12 -> 1,501.38
12% allrecipes loadtime android-hw-p2-8-0-android-aarch64-shippable opt warm 1,870.04 -> 1,654.21
11% instagram LastVisualChange android-hw-p2-8-0-android-aarch64-shippable opt cold 2,235.08 -> 1,980.83
11% cnn PerceptualSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 1,952.75 -> 1,731.50
11% instagram loadtime android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,711.62 -> 2,405.96
11% cnn SpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 2,007.08 -> 1,781.42
11% amazon LastVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,723.38 -> 2,417.50
11% facebook loadtime android-hw-p2-8-0-android-aarch64-shippable opt warm 810.96 -> 720.00
11% microsoft-support loadtime android-hw-p2-8-0-android-aarch64-shippable opt warm 1,378.21 -> 1,225.88
11% microsoft-support loadtime android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,828.04 -> 2,517.54
11% cnn LastVisualChange android-hw-p2-8-0-android-aarch64-shippable opt warm 2,104.42 -> 1,874.08
11% reddit PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,263.58 -> 2,015.83
11% facebook LastVisualChange android-hw-p2-8-0-android-aarch64-shippable opt warm 654.00 -> 582.83
11% reddit SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt cold 5,917.00 -> 5,281.00
11% reddit ContentfulSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt cold 4,260.33 -> 3,804.33
11% reddit LastVisualChange android-hw-p2-8-0-android-aarch64-shippable opt warm 2,779.42 -> 2,483.25
11% youtube-watch android-hw-p2-8-0-android-aarch64-shippable opt warm 528.20 -> 472.38
11% allrecipes SpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 1,114.75 -> 997.08
11% instagram SpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 1,156.08 -> 1,034.75
11% reddit SpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt cold 2,763.08 -> 2,472.83
10% allrecipes LastVisualChange android-hw-p2-8-0-android-aarch64-shippable opt warm 1,993.67 -> 1,786.00
10% allrecipes PerceptualSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 966.50 -> 867.33
10% reddit PerceptualSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 1,105.25 -> 992.08
10% reddit loadtime android-hw-p2-8-0-android-aarch64-shippable opt warm 1,030.12 -> 925.96
10% facebook-cristiano loadtime android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,665.58 -> 1,498.08
10% facebook-cristiano loadtime android-hw-p2-8-0-android-aarch64-shippable opt warm 781.67 -> 705.88
10% cnn ContentfulSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 4,299.92 -> 3,883.17
10% reddit LastVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt cold 6,853.08 -> 6,190.08
10% instagram PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt cold 1,767.17 -> 1,597.17
10% cnn loadtime android-hw-g5-7-0-arm7-api-16-shippable opt warm 3,926.33 -> 3,549.62
10% cnn SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 4,763.92 -> 4,311.00
10% reddit android-hw-g5-7-0-arm7-api-16-shippable opt cold 3,156.87 -> 2,857.02
9% reddit LastVisualChange android-hw-p2-8-0-android-aarch64-shippable opt cold 3,391.92 -> 3,069.92
9% allrecipes PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,361.92 -> 2,138.33
9% facebook LastVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,243.42 -> 1,126.00
9% cnn FirstVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 4,168.00 -> 3,775.42
9% reddit ContentfulSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt cold 1,968.17 -> 1,782.83
9% cnn fcp android-hw-g5-7-0-arm7-api-16-shippable opt warm 4,157.29 -> 3,766.62
9% allrecipes loadtime android-hw-g5-7-0-arm7-api-16-shippable opt warm 4,404.29 -> 3,990.75
9% allrecipes LastVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 4,579.08 -> 4,151.00
9% cnn PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 4,452.92 -> 4,039.58
9% cnn LastVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 5,123.67 -> 4,649.75
9% jianshu loadtime android-hw-p2-8-0-android-aarch64-shippable opt warm 668.38 -> 606.92
9% instagram SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,528.17 -> 2,298.50
9% allrecipes SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,539.00 -> 2,309.92
9% jianshu android-hw-p2-8-0-android-aarch64-shippable opt warm 646.42 -> 588.18
9% facebook-cristiano LastVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,539.33 -> 1,400.83
9% instagram loadtime android-hw-g5-7-0-arm7-api-16-shippable opt cold 3,014.79 -> 2,743.79
9% jianshu loadtime android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,436.58 -> 1,307.75
9% reddit PerceptualSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt cold 1,912.17 -> 1,741.25
9% facebook ContentfulSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 517.92 -> 472.00
9% imdb android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,839.71 -> 1,677.55
9% facebook-cristiano LastVisualChange android-hw-p2-8-0-android-aarch64-shippable opt warm 725.62 -> 661.75
9% allrecipes loadtime android-hw-g5-7-0-arm7-api-16-shippable opt cold 5,785.02 -> 5,281.25
9% imdb PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 4,811.67 -> 4,392.75
9% allrecipes LastVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt cold 6,066.42 -> 5,538.42
8% instagram LastVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,766.08 -> 2,533.92
8% youtube-watch PerceptualSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 661.96 -> 606.75
8% facebook android-hw-g5-7-0-arm7-api-16-shippable opt warm 856.75 -> 785.41
8% facebook PerceptualSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 443.75 -> 407.25
8% cnn LastVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt cold 6,764.33 -> 6,210.50
8% instagram PerceptualSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 772.83 -> 709.83
8% bbc SpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 920.38 -> 845.50
8% espn SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 4,771.42 -> 4,384.00
8% jianshu fcp android-hw-p2-8-0-android-aarch64-shippable opt warm 676.25 -> 621.50
8% bbc PerceptualSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 949.21 -> 873.08
8% cnn ContentfulSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt cold 4,964.96 -> 4,569.33
8% instagram PerceptualSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt cold 889.75 -> 818.83
8% instagram PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,464.79 -> 1,348.92
8% cnn SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt cold 5,669.04 -> 5,221.00
8% facebook SpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 427.17 -> 393.50
8% allrecipes PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt cold 3,355.08 -> 3,091.58
8% microsoft-support android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,111.78 -> 1,024.80
8% espn FirstVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 3,418.50 -> 3,151.58
8% facebook android-hw-p2-8-0-android-aarch64-shippable opt warm 441.72 -> 407.21
8% allrecipes SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt cold 3,675.83 -> 3,389.58
8% facebook PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 846.42 -> 780.58
8% cnn-ampstories fcp android-hw-p2-8-0-android-aarch64-shippable opt live warm 424.92 -> 392.00
8% espn ContentfulSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 3,432.62 -> 3,166.83
8% youtube-watch SpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 860.00 -> 793.50
8% espn fcp android-hw-g5-7-0-arm7-api-16-shippable opt warm 3,407.58 -> 3,144.50
8% jianshu ContentfulSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 689.17 -> 636.25
8% jianshu FirstVisualChange android-hw-p2-8-0-android-aarch64-shippable opt warm 689.17 -> 636.25
8% jianshu LastVisualChange android-hw-p2-8-0-android-aarch64-shippable opt warm 689.17 -> 636.25
8% jianshu PerceptualSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 689.17 -> 636.25
8% jianshu SpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 689.17 -> 636.25
8% bbc LastVisualChange android-hw-p2-8-0-android-aarch64-shippable opt warm 1,477.75 -> 1,366.33
7% reddit PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt cold 4,164.62 -> 3,853.50
7% facebook SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 808.50 -> 748.33
7% facebook-cristiano PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 972.92 -> 902.50
7% youtube-watch loadtime android-hw-p2-8-0-android-aarch64-shippable opt warm 773.56 -> 717.71
7% allrecipes ContentfulSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 698.29 -> 647.92
7% cnn PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt cold 5,028.17 -> 4,668.92
7% instagram SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt cold 2,926.25 -> 2,717.25
7% imdb PerceptualSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 2,787.17 -> 2,588.83
7% espn SpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 1,957.08 -> 1,818.67
7% espn SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt cold 6,938.88 -> 6,452.33
7% facebook fcp android-hw-g5-7-0-arm7-api-16-shippable opt warm 721.12 -> 670.58
7% facebook FirstVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 732.75 -> 682.50
7% youtube-watch loadtime android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,656.62 -> 1,543.62
7% google-maps PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,002.33 -> 934.25
7% facebook ContentfulSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 732.75 -> 683.25
7% youtube-watch LastVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,060.58 -> 1,923.33
7% facebook-cristiano android-hw-g5-7-0-arm7-api-16-shippable opt warm 786.14 -> 733.90
7% cnn-ampstories PerceptualSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt live warm 459.50 -> 429.00
7% google-maps SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,009.75 -> 943.17
7% google-maps android-hw-g5-7-0-arm7-api-16-shippable opt warm 940.64 -> 878.73
7% cnn-ampstories LastVisualChange android-hw-p2-8-0-android-aarch64-shippable opt live warm 515.54 -> 481.75
7% facebook-cristiano PerceptualSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 502.83 -> 470.17
6% imdb PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt cold 5,444.23 -> 5,095.92
6% allrecipes ContentfulSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt cold 2,901.33 -> 2,717.08
6% ebay-kleinanzeigen PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,441.83 -> 1,350.42
6% cnn-ampstories ContentfulSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt live warm 439.42 -> 411.58
6% cnn-ampstories FirstVisualChange android-hw-p2-8-0-android-aarch64-shippable opt live warm 436.83 -> 409.25
6% cnn android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,709.81 -> 2,541.04
6% facebook fcp android-hw-p2-8-0-android-aarch64-shippable opt warm 384.88 -> 360.96
6% cnn-ampstories ContentfulSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 697.17 -> 654.25
6% youtube-watch LastVisualChange android-hw-p2-8-0-android-aarch64-shippable opt warm 1,013.17 -> 950.75
6% cnn-ampstories LastVisualChange android-hw-p2-8-0-android-aarch64-shippable opt warm 697.08 -> 654.25
6% cnn-ampstories loadtime android-hw-p2-8-0-android-aarch64-shippable opt warm 594.25 -> 557.88
6% cnn-ampstories SpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 696.75 -> 654.25
6% cnn-ampstories PerceptualSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 696.58 -> 654.25
6% bbc android-hw-p2-8-0-android-aarch64-shippable opt warm 465.82 -> 437.57
6% cnn-ampstories FirstVisualChange android-hw-p2-8-0-android-aarch64-shippable opt warm 696.38 -> 654.25
6% google-maps loadtime android-hw-p2-8-0-android-aarch64-shippable opt warm 640.17 -> 601.46
6% cnn-ampstories SpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt live warm 439.54 -> 413.00
6% espn fcp android-hw-p2-8-0-android-aarch64-shippable opt warm 1,632.21 -> 1,533.58
6% espn loadtime android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,881.54 -> 2,708.67
6% cnn-ampstories LastVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt cold live 2,051.92 -> 1,929.33
6% google-maps FirstVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 921.92 -> 867.25
6% google-maps fcp android-hw-g5-7-0-arm7-api-16-shippable opt warm 911.83 -> 858.21
6% ebay-kleinanzeigen LastVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,960.75 -> 2,787.67
6% cnn-ampstories LastVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt live warm 1,204.25 -> 1,134.17
6% imdb LastVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 10,057.08 -> 9,482.08
6% espn FirstVisualChange android-hw-p2-8-0-android-aarch64-shippable opt warm 1,641.67 -> 1,548.17
6% cnn-ampstories fcp android-hw-g5-7-0-arm7-api-16-shippable opt live warm 1,184.31 -> 1,116.92
6% ebay-kleinanzeigen SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,228.25 -> 1,158.75
6% espn android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,964.27 -> 1,853.91
6% espn PerceptualSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 2,289.42 -> 2,161.00
6% cnn-ampstories fcp android-hw-p2-8-0-android-aarch64-shippable opt warm 683.66 -> 645.54
6% facebook-cristiano android-hw-p2-8-0-android-aarch64-shippable opt warm 406.60 -> 384.25
5% cnn-ampstories PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt live warm 1,197.92 -> 1,133.75
5% cnn-ampstories loadtime android-hw-p2-8-0-android-aarch64-shippable opt live warm 228.94 -> 216.67
5% cnn-ampstories ContentfulSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt live warm 1,197.75 -> 1,133.67
5% cnn-ampstories FirstVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt live warm 1,197.75 -> 1,133.67
5% cnn-ampstories SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt live warm 1,197.75 -> 1,133.67
5% bbc ContentfulSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 417.88 -> 395.75
5% espn FirstVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt cold 6,012.00 -> 5,694.00
5% facebook-cristiano SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 764.17 -> 723.92
5% cnn-ampstories SpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt cold live 723.50 -> 685.75
5% google-maps ContentfulSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt cold 1,107.83 -> 1,050.50
5% google-maps FirstVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt cold 1,087.17 -> 1,030.83
5% ebay-kleinanzeigen-search FirstVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 915.00 -> 867.67
5% espn ContentfulSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt cold 6,033.75 -> 5,721.92
5% facebook-cristiano SpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 429.54 -> 407.75
5% google-maps android-hw-p2-8-0-android-aarch64-shippable opt warm 512.77 -> 486.78
5% bbc FirstVisualChange android-hw-p2-8-0-android-aarch64-shippable opt warm 400.17 -> 380.00
5% ebay-kleinanzeigen-search fcp android-hw-g5-7-0-arm7-api-16-shippable opt warm 905.46 -> 859.79
5% google-maps fcp android-hw-g5-7-0-arm7-api-16-shippable opt cold 1,075.29 -> 1,021.21
5% ebay-kleinanzeigen FirstVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 860.58 -> 817.50
5% ebay-kleinanzeigen android-hw-g5-7-0-arm7-api-16-shippable opt warm 942.19 -> 895.66
5% ebay-kleinanzeigen-search SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,992.08 -> 1,894.17
5% facebook-cristiano fcp android-hw-g5-7-0-arm7-api-16-shippable opt warm 702.10 -> 667.75
5% imdb LastVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt cold 10,630.58 -> 10,117.17
5% stackoverflow loadtime android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,049.69 -> 999.29
5% facebook-cristiano FirstVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 715.00 -> 681.08
5% ebay-kleinanzeigen-search LastVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 2,706.50 -> 2,579.92
5% cnn-ampstories android-hw-p2-8-0-android-aarch64-shippable opt live warm 160.39 -> 152.91
5% ebay-kleinanzeigen-search android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,030.51 -> 982.42
5% google-maps ContentfulSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,256.83 -> 1,198.25
5% ebay-kleinanzeigen-search PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,848.33 -> 1,764.50
5% google-maps PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt cold 1,173.75 -> 1,120.67
4% google-maps PerceptualSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 651.50 -> 623.00
4% cnn-ampstories loadtime android-hw-g5-7-0-arm7-api-16-shippable opt live warm 526.38 -> 503.67
4% google-maps SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt cold 1,172.83 -> 1,122.67
4% cnn-ampstories fcp android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,411.58 -> 1,353.21
4% imdb SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,758.50 -> 1,687.75
4% youtube fcp android-hw-g5-7-0-arm7-api-16-shippable opt warm 882.38 -> 847.58
4% cnn-ampstories ContentfulSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,422.58 -> 1,367.58
4% cnn-ampstories FirstVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,422.58 -> 1,367.58
4% cnn-ampstories LastVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,422.58 -> 1,367.58
4% cnn-ampstories PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,422.58 -> 1,367.58
4% cnn-ampstories SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,422.58 -> 1,367.58
4% facebook-cristiano ContentfulSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 386.67 -> 371.83
4% youtube SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 883.08 -> 849.58
4% youtube LastVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 968.92 -> 932.67
4% google-maps ContentfulSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 998.17 -> 961.00
4% amazon ContentfulSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 682.12 -> 657.08
4% facebook-cristiano ContentfulSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 724.83 -> 698.58
4% amazon SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 661.62 -> 638.00
4% amazon PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 667.75 -> 644.08
4% youtube android-hw-g5-7-0-arm7-api-16-shippable opt warm 670.76 -> 647.29
3% ebay-kleinanzeigen-search SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt cold 2,792.88 -> 2,695.75
3% amazon android-hw-g5-7-0-arm7-api-16-shippable opt warm 516.97 -> 499.28
3% youtube PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 667.08 -> 644.33
3% amazon FirstVisualChange android-hw-g5-7-0-arm7-api-16-shippable opt warm 614.17 -> 593.58
3% google-maps SpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 1,253.08 -> 1,211.75
3% booking SpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 974.79 -> 943.17
3% imdb LastVisualChange android-hw-p2-8-0-android-aarch64-shippable opt cold 7,684.00 -> 7,436.08
3% stackoverflow android-hw-g5-7-0-arm7-api-16-shippable opt warm 646.26 -> 625.84
3% booking loadtime android-hw-g5-7-0-arm7-api-16-shippable opt warm 1,696.90 -> 1,643.79
3% youtube ContentfulSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 613.54 -> 594.83
3% amazon fcp android-hw-g5-7-0-arm7-api-16-shippable opt warm 602.62 -> 584.50
3% imdb LastVisualChange android-hw-p2-8-0-android-aarch64-shippable opt warm 7,117.42 -> 6,905.25
3% amazon loadtime android-hw-g5-7-0-arm7-api-16-shippable opt warm 552.67 -> 536.54
3% booking ContentfulSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 763.21 -> 741.25
3% booking android-hw-g5-7-0-arm7-api-16-shippable opt warm 995.38 -> 967.39
3% booking PerceptualSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt warm 750.50 -> 729.50
2% booking fcp android-hw-g5-7-0-arm7-api-16-shippable opt cold 736.58 -> 719.58

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=27029

Comment 12

[Florin Strugariu [:Bebe]]

== Change summary for alert #27081 (as of Mon, 28 Sep 2020 13:43:12 GMT) ==

Improvements:

10% Base Content Heap Unclassified windows10-64-shippable opt 1,622,429.33 -> 1,457,234.67
8% JS windows10-64-shippable opt tp6 190,971,108.11 -> 174,915,738.28
8% JS macosx1014-64-shippable opt tp6 186,754,827.05 -> 172,371,162.61
8% JS linux1804-64-shippable opt tp6 185,853,299.08 -> 171,849,496.59
8% JS windows10-64-shippable-qr opt 97,591,875.52 -> 90,262,300.52
8% JS linux1804-64-shippable opt tp6 185,501,966.56 -> 171,587,517.49
7% JS linux1804-64-shippable-qr opt tp6 184,918,329.45 -> 171,325,809.82
7% JS windows10-64-shippable-qr opt tp6 189,339,620.66 -> 175,767,115.09
7% JS windows10-64-shippable opt 97,410,591.63 -> 90,598,561.47
7% JS linux1804-64-shippable-qr opt 94,809,809.66 -> 88,343,288.79
7% JS linux1804-64-shippable opt 94,184,549.85 -> 87,851,349.67
7% JS macosx1014-64-shippable opt 96,625,942.34 -> 90,290,990.34
5% Base Content JS macosx1014-64-shippable opt 3,062,555.33 -> 2,913,528.00
5% Base Content JS windows10-64-shippable opt 3,119,916.67 -> 2,968,104.00
5% Explicit Memory windows10-64-shippable opt tp6 467,666,271.18 -> 445,213,310.82
5% Base Content JS windows10-64-shippable-qr opt 3,075,187.33 -> 2,927,890.67
5% Base Content JS linux1804-64-shippable opt 3,059,026.00 -> 2,915,986.67
5% Base Content JS linux1804-64-shippable-qr opt 3,059,228.00 -> 2,915,994.00
5% JS windows7-32-shippable opt tp6 146,274,924.96 -> 139,448,867.17
4% JS windows7-32-shippable opt 73,005,048.12 -> 69,866,977.69
4% Base Content Heap Unclassified linux1804-64-shippable opt 4,206,260.67 -> 4,035,245.33
4% Base Content Heap Unclassified linux1804-64-shippable-qr opt 4,248,228.00 -> 4,079,125.33
4% Explicit Memory macosx1014-64-shippable opt tp6 494,696,651.70 -> 475,026,063.72
4% Explicit Memory linux1804-64-shippable opt tp6 486,940,813.86 -> 467,916,517.92
4% Base Content JS windows7-32-shippable opt 2,395,113.33 -> 2,304,774.00
4% Explicit Memory windows10-64-shippable-qr opt tp6 476,956,818.36 -> 460,244,757.78
3% Explicit Memory windows7-32-shippable opt tp6 376,791,581.64 -> 364,362,489.69
3% Base Content Explicit linux1804-64-shippable-qr opt 11,004,416.00 -> 10,666,837.33
3% Heap Unclassified windows10-64-shippable-qr opt tp6 71,970,235.48 -> 69,764,624.86
3% Base Content Explicit linux1804-64-shippable opt 10,935,040.00 -> 10,606,933.33
3% Explicit Memory windows10-64-shippable-qr opt 366,002,425.80 -> 355,533,748.74
3% Explicit Memory linux1804-64-shippable opt 367,409,561.67 -> 357,563,571.10
3% Explicit Memory windows10-64-shippable opt 348,791,747.94 -> 339,719,050.33
2% Heap Unclassified windows10-64-shippable opt 51,495,881.98 -> 50,220,719.07
2% Explicit Memory macosx1014-64-shippable opt 385,573,338.34 -> 376,379,165.44
2% Resident Memory linux1804-64-shippable opt tp6 739,654,467.52 -> 724,716,473.42

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=27081

Comment 13

[Jan de Mooij [:jandem]]

Attachment: Bug 1666417 part 5 - Add debuggee check to AddInlinedCompilations. r?iain!

The breakpoint-14.js jit-test had intermittent failures on Windows. Fortunately
they could be reproduced with rr chaos mode.

Comment 14

[Jan de Mooij [:jandem]]

Attachment: Bug 1666417 part 6 - Disable AssertValid* calls on simulator builds. r?iain!

This fixes timeouts when running certain jit-tests. This patch is a measurable
speedup when running all jit-tests with a simulator build.

Depends on D91897

Comment 15

[Jan de Mooij [:jandem]]

Attachment: Bug 1666417 part 7 - Fix ASan test timeouts. r?iain!

Depends on D91898

Comment 16

[Jan de Mooij [:jandem]]

Attachment: Bug 1666417 part 8 - Fix check to work on no-jit builds. r?iain!

This fixes some jit-test failures with a no-jit build. That's because (annoyingly)
JS_GetGlobalJitCompilerOption always returns false in that configuration.

Depends on D91899

Comment 17

[Jan de Mooij [:jandem]]

Attachment: Bug 1666417 part 9 - Fix some arm64-simulator test failures. r?iain!

The change in Simulator::overRecursed fixes a test failure, the old code didn't
make sense. Now it matches the ARM32 and MIPS simulators.

The other changes may not be necessary after part 7, but it makes sense to reduce
the excessive iteration counts.

Depends on D91900

Comment 18

[Jan de Mooij [:jandem]]

Attachment: Bug 1666417 part 10 - Enable Warp by default in the JS shell. r?iain!

Changes the JitOptions to match setWarpEnabled(true) and makes --no-warp disable Warp.

Depends on D91901

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8168d6f65b2
part 4 - Add a temporary SM(nowarp) job. r=sfink,jmaher

Comment 20

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/e8168d6f65b2

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9813153bab06
part 5 - Add debuggee check to AddInlinedCompilations. r=iain
https://hg.mozilla.org/integration/autoland/rev/3be1201498e2
part 6 - Disable AssertValid* calls on simulator builds. r=iain
https://hg.mozilla.org/integration/autoland/rev/a3a3cf901fd0
part 7 - Fix ASan test timeouts. r=iain
https://hg.mozilla.org/integration/autoland/rev/780e65c0e175
part 8 - Fix check to work on no-jit builds. r=iain
https://hg.mozilla.org/integration/autoland/rev/a9b6455b3500
part 9 - Fix some arm64-simulator test failures. r=iain

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe936dd686a0
part 10 - Enable Warp by default in the JS shell. r=iain

Comment 23

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/9813153bab06
https://hg.mozilla.org/mozilla-central/rev/3be1201498e2
https://hg.mozilla.org/mozilla-central/rev/a3a3cf901fd0
https://hg.mozilla.org/mozilla-central/rev/780e65c0e175
https://hg.mozilla.org/mozilla-central/rev/a9b6455b3500
https://hg.mozilla.org/mozilla-central/rev/fe936dd686a0

Comment 24

[Joel Maher ( :jmaher ) (UTC -8)]

:jandem, is IonBuilder/TI removed? Just following up on the temporary nowarp job.

Comment 25

[Jan de Mooij [:jandem]]

(In reply to Joel Maher ( :jmaher ) (UTC -0400) from comment #24)

:jandem, is IonBuilder/TI removed? Just following up on the temporary nowarp job.

Not yet. The plan is to wait at least until the next cycle, so hopefully next week we can remove the nowarp job.

Comment 26

[Zhao Jiazhong]

Hi, the Octane2 benchmark regressed about 42% (25959 -> 14883), and JetStream2 regressed about 20% (73.973 -> 58.898) on my machine (i5-7300u, 2C4T, 2.6-3.5GHz) with warp enabled in the JS shell. Is it supposed to be? Thanks!

Comment 27

[Jan de Mooij [:jandem]]

(In reply to Zhao Jiazhong from comment #26)

See bug 1667797 comment 2.

Comment 28

[Zhao Jiazhong]

(In reply to Jan de Mooij [:jandem] from comment #27)

(In reply to Zhao Jiazhong from comment #26)

See bug 1667797 comment 2.

Okay, thanks for reply.