1759412 - "too much recursion". on accepting cookies.

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Karl Dubost💡 :karlcow]

[Tracking Requested - why for this release]:
Probably would be good to understand why this is failing only on windows.
Maybe there are similar bugs. And it seems to be a regression.

This was originally posted on https://github.com/webcompat/web-bugs/issues/98474

1. Go to https://empto.de/anmelden with Firefox on Windows.
2. Accept Cookie (Erlauben)

Expected:
The form displays

Actual:
"Login" form is not displayed.
browser console displays "too much recursion".

This doesn't reproduce on Firefox 100 Nightly on macOS.

An attempt at a regression gives
Last good revision: 81d47e62000723a24bb20f1abdda51cfc62c553f (2020-09-22)
First bad revision: efc5aeff23bd99963e66e314ddd0104740a9d0e5 (2020-09-23)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=81d47e62000723a24bb20f1abdda51cfc62c553f&tochange=efc5aeff23bd99963e66e314ddd0104740a9d0e5

but that's still a bit large, maybe it's possible to do better.

Comment 1

[Alice0775 White]

I can reproduce the issue in Nightly100.0a1 Windows10.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4548a773cf089b4f42b83d990f3e6fa5f0c55743&tochange=91b890df65c564e5bbcd24b30ed576a045211fc5

Setting only javascript.options.ion.threshold to 1000 resolves the problem in the bad build and Nightly100.0a1.
However, leaving javascript.options.ion.threshold at 1500(default) and setting javascript.options.warp to false does not solve the problem in the bad build.
(And javascript.options.warp is not present in Nightly100.0a1).

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1666417

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:jandem, since you are the author of the regressor, bug 1666417, could you take a look?
For more information, please visit auto_nag documentation.

Comment 4

[Jan de Mooij [:jandem]]

I'm pretty sure this is being caused by us not optimizing scripted calls at FunCall ops. I think we can fix this now post-Warp.

Comment 5

[Jan de Mooij [:jandem]]

Can anyone confirm this is fixed in the latest Nightly?

Comment 6

[Jan de Mooij [:jandem]]

(In reply to Jan de Mooij [:jandem] from comment #5)

Can anyone confirm this is fixed in the latest Nightly?

I'm just going to close this because bug 1760605 should have fixed it.

If this is still broken, please reopen.

Comment 7

[Ardelean Oana, Desktop QA [:oardelean]]

I managed to reproduce this issue on Firefox 98.0(20220304153049) on Win10 64-bits. Verified as fixed on Firefox 100.0(20220425210429) and Nightly 101.0a1(20220425213655) on Win10 64-bits and Ubuntu 20.04.