Tests for assert.positiveNumber are missing
Categories
(Testing :: Marionette, defect, P3)
Tracking
(firefox101 fixed)
| Tracking | Status | |
|---|---|---|
| firefox101 | --- | fixed |
People
(Reporter: whimboo, Assigned: sabina.zaripova, Mentored)
Details
(Whiteboard: [lang=js])
Attachments
(1 file, 1 obsolete file)
As noticed while working on the spec, our assert.positiveNumber implementation doesn't check for the maximum safe integer value similar to what assert.number does.
We should get this corrected.
hi, Is this bug still open. Can you assign it to me ? I would love to work on it.
|
||
Comment 2•3 months ago
|
||
Hi, is anyone working on it ?I would like to work on this issue.
|
Reporter | |
Comment 3•3 months ago
|
||
(In reply to Garima from comment #1)
hi, Is this bug still open. Can you assign it to me ? I would love to work on it.
Yes, this bug is still open as you can see (not marked as fixed) and as such feel free to take it. Note that bugs are assigned automatically when a patch gets uploaded. In case of questions don't hesitate to ask. Thanks.
Can you please guide me how to start with it. Actually I am new to open source. How can I see the way things are working And how they should actually work on my local? And from where should I start? Even small help will work. I genuinely want to learn.
Thank You
|
|
Reporter | |
Comment 5•3 months ago
|
||
A good documentation for getting started with Marionette (WebDriver) development you can find here:
https://firefox-source-docs.mozilla.org/testing/marionette/NewContributors.html
It has links to answers for all of your questions above. But don't hesitate to ask further, as you already did on Element. Thanks!
|
|
Reporter | |
Comment 7•3 months ago
|
||
Hi Garima, I want to check back and ask if everything is clear and that you want to still work on this bug. Please let us know. Thanks.
I am so sorry actually I had exams and therefore I was not able to give time to this. I'll now start looking at it again
Hi, Went through the doc but its still confusing from where to begin. Can I first begin with cloning this code into my local. But cannot even find clone option. Plz help
|
||
Comment 10•3 months ago
|
||
Or need to setup marionette first
|
Assignee | |
Comment 11•3 months ago
|
||
|
||
Updated•3 months ago
|
|
|
Reporter | |
Updated•2 months ago
|
|
|
Reporter | |
Comment 12•2 months ago
|
||
As discovered while reviewing the patch we already have a finite check for assert.positiveNumber but actually not a single test. So I've updated the bug's summary to reflect that we want to have this test.
|
|
Assignee | |
Comment 13•2 months ago
|
||
|
|
||
Updated•2 months ago
|
|
||
Comment 14•2 months ago
|
||
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/381966465ebe [remote] added tests to Assert.positiveNumber. r=whimboo,jdescottes,webdriver-reviewers
|
||
Comment 15•2 months ago
|
||
| bugherder | ||
|
|
||
Updated•2 months ago
|
Description
•