Closed Bug 1666456 Opened 2 years ago Closed 2 months ago

Tests for assert.positiveNumber are missing

Categories

(Testing :: Marionette, defect, P3)

Default
defect

Tracking

(firefox101 fixed)

RESOLVED FIXED
101 Branch
Tracking Status
firefox101 --- fixed

People

(Reporter: whimboo, Assigned: sabina.zaripova, Mentored)

Details

(Whiteboard: [lang=js])

Attachments

(1 file, 1 obsolete file)

As noticed while working on the spec, our assert.positiveNumber implementation doesn't check for the maximum safe integer value similar to what assert.number does.

https://searchfox.org/mozilla-central/rev/b58ca45005fe02077c92779483d1b60e9a49687c/testing/marionette/assert.js#228-246

We should get this corrected.

hi, Is this bug still open. Can you assign it to me ? I would love to work on it.

Hi, is anyone working on it ?I would like to work on this issue.

Flags: needinfo?(hskupin)

(In reply to Garima from comment #1)

hi, Is this bug still open. Can you assign it to me ? I would love to work on it.

Yes, this bug is still open as you can see (not marked as fixed) and as such feel free to take it. Note that bugs are assigned automatically when a patch gets uploaded. In case of questions don't hesitate to ask. Thanks.

Can you please guide me how to start with it. Actually I am new to open source. How can I see the way things are working And how they should actually work on my local? And from where should I start? Even small help will work. I genuinely want to learn.
Thank You

A good documentation for getting started with Marionette (WebDriver) development you can find here:
https://firefox-source-docs.mozilla.org/testing/marionette/NewContributors.html

It has links to answers for all of your questions above. But don't hesitate to ask further, as you already did on Element. Thanks!

Flags: needinfo?(hskupin)

Ok Thanks

Hi Garima, I want to check back and ask if everything is clear and that you want to still work on this bug. Please let us know. Thanks.

Flags: needinfo?(garimakotwani2001)

I am so sorry actually I had exams and therefore I was not able to give time to this. I'll now start looking at it again

Flags: needinfo?(garimakotwani2001)

Hi, Went through the doc but its still confusing from where to begin. Can I first begin with cloning this code into my local. But cannot even find clone option. Plz help

Or need to setup marionette first

Assignee: nobody → sabina.zaripova
Status: NEW → ASSIGNED
Summary: assert.positiveNumber doesn't check for maximum safe integer → Tests for assert.positiveNumber are missing

As discovered while reviewing the patch we already have a finite check for assert.positiveNumber but actually not a single test. So I've updated the bug's summary to reflect that we want to have this test.

Attachment #9273278 - Attachment description: Bug 1666456 - added tests to positiveNumber. r=whimboo,jdescottes → Bug 1666456 - [remote] added tests to Assert.positiveNumber. r=whimboo,jdescottes
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/381966465ebe
[remote] added tests to Assert.positiveNumber. r=whimboo,jdescottes,webdriver-reviewers
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
Attachment #9272481 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.