Re-enable browser_net_simple-request-data.js early request data assertions
Categories
(DevTools :: Netmonitor, enhancement, P2)
Tracking
(Fission Milestone:Future)
Fission Milestone | Future |
People
(Reporter: ochameau, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-fission-future)
Before bug 1663614, browser_net_simple-request-data.js was disabling batching and throttling in order to ensure receiving server event very early.
But this is suject to races if the events aren't received early enough.
This test tries to assert the behavior of slow-to-update requests, where we receive data piece by piece.
Julian suggested a way to address that in a safe way, without disabling any production behavior that can be batching and/or throttling:
https://phabricator.services.mozilla.com/D89628#inline-513707
Tried a few things, we can either tackle this here or in a follow up:
1/ The only asserts which fail are the "not set yet" ones. If we comment them out then the test passes with the throttling. We could comment them out and file another bug to really test the "not set yet" part (see 2/ for how to do so)
2/ We could also slow down the response of the sjs. If we do that, we will receive the events in different batches, and the test will succeed. My code to slow down the requests slightly modifies headers though - not sure why - so other asserts needs to be updated. We can also just use this approach for a dedicated smaller test. It might be racy, so having a smaller, more focused test is probably the best call.
Comment 1•4 years ago
|
||
Tracking dt-fission-m2-reserve bugs for Fission Beta milestone (M7).
Updated•4 years ago
|
Comment 2•4 years ago
|
||
Bulk move of all dt-fission-m2-reserve bugs to Fission MVP milestone.
Comment 3•4 years ago
|
||
Moving old "dt-fission-m2-reserve" bugs to "dt-fission-future" because they don't block Fission MVP.
Description
•