1666537 - getSelection().modify("extend", "left", "lineboundary") in mixed RTL context behaves wrong

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

• An RTL line with only LTR text nodes: It always goes right regardless of the second parameter
• An RTL line that ends with LTR text node: It ignores the last node and terminates before it. This also happens when dragging by mouse to the left, but it shouldn't.

Putting this in Layout module as the core issue is in nsIFrame::PeekOffsetForLineEdge.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1666537 - Peek logical line end in bidi context r=emilio

Previously it peeked to the visually leftmost/rightmost position, while such position can actually be a middle of the line in mixed bidi context. This patch corrects the behavior.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b0c73503e38
Peek logical line end in bidi context r=emilio,jfkthame

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/25790 for changes under testing/web-platform/tests

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/9b0c73503e38

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham