1666586 - On Save Recs – UI tweaks

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Gavin Suntop [:gvn] (they/them)]

• fix space between the Similar Stories header and the first recommended item
• the open in new tab icon is missing
• fix the bottom padding/spacing between the last recommended item and and the bottom edge of the extension
• More shouldn’t be capitalized in Learn More
• Show Similar Story when there’s only one recommended item

https://www.figma.com/file/BWl63Zb4RUdoTwIATu1skG/Story-Recommendations-in-Save-Doorhanger?node-id=98%3A2

Comment 1

[Gavin Suntop [:gvn] (they/them)]

Attachment: Bug 1666586 - save on recs UI tweaks

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76491cb47cc8
save on recs UI tweaks r=thecount

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/76491cb47cc8

Comment 4

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: Small updates to UI to improve this for users before preffing it on.

Comment 5

[Julien Cristau [:jcristau]]

Doesn't sound like this needs tracking. If you want it on 82 please request uplift asap though.

Comment 6

[Scott [:thecount] Downe]

Comment on attachment 9177479 [details]
Bug 1666586 - save on recs UI tweaks

Beta/Release Uplift Approval Request

• User impact if declined: UI/UX improvements to a feature we are looking to pref on.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Set extensions.pocket.onSaveRecs to true.

2. Ensure you're in an en-US, en-GB, or en-CA browser.
3. Restart.
4. Open a new tab.
5. Click a newtab story.
6. Click the save to pocket button.

Expected:

• Should be an icon on the right of each article.
• More shouldn’t be capitalized in Learn More
• There were a few pixel spacing tweaks, but for the most part I don't think it's worth measuring. We can let design go into that. For QA, just make sure that the spacing and alignment of items seems reasonable.

• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): It's just css changes, and the main feature is off by default in beta, but we intend to turn it on in another uplift once we fix up some of these tweaks.
• String changes made/needed: none

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9177479 [details]
Bug 1666586 - save on recs UI tweaks

approved for 82.0b6

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0be9d2aecf2d

Comment 9

[Robert Martin [:romartin], Ecosystem QA]

I have verified the following by using the steps provided in comment 6:

• An icon is correctly displayed on the right side of each article.
• "More" is no longer capitalized in the "Learn more" hyperlink.
• Spacing and alignment are reasonable.

I've done the verification using Firefox Nightly 83.0a1 (Build ID: 20201001094020) and Firefox Beta 82.0b6 (Build ID: 20201001171107) on Windows 10 x64, macOS 10.15.6, and Ubuntu Linux 20.04 x64.