Closed
Bug 1666609
Opened 5 years ago
Closed 5 years ago
Media Session onFullscreen not called
Categories
(GeckoView :: Media, defect, P1)
Tracking
(firefox83 fixed)
RESOLVED
FIXED
83 Branch
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: esawin, Assigned: esawin)
References
Details
(Whiteboard: [geckoview:m83])
Attachments
(2 files, 1 obsolete file)
The refactoring of the MediaUtils (bug 1623715) has introduced an error, where we call into a non-existing (renamed) utility function.
We also didn't have any test coverage for onFullscreen, which we should change.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D91054
|
||
Updated•5 years ago
|
Attachment #9177216 -
Attachment is obsolete: true
|
||
Updated•5 years ago
|
Severity: -- → S3
Priority: -- → P1
Whiteboard: [geckoview:m83]
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b1c1926a7bee
[1.0] Fix undefined function call in onFullscreen handling. r=geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/8fc5bd25fa72
[2.0] Add Media Session onFullscreen test. r=geckoview-reviewers,agi
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b1c1926a7bee
https://hg.mozilla.org/mozilla-central/rev/8fc5bd25fa72
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
|
||
Comment 6•3 years ago
|
||
Moving some media bugs to the new GeckoView::Media component.
Component: General → Media
You need to log in
before you can comment on or make changes to this bug.
Description
•