1666617 - Add RefreshObserver markers with backtraces

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Markus Stange [:mstange]]

As proposed in bug 1661054:
When the refresh driver keeps firing, and it is doing so because it still has observers, it would be nice to get some information about the observers from a profile. We can provide that information in a RefreshObservers profiler marker.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1666617 - Add RefreshObserver profiler markers, r=smaug

Comment 2

[Markus Stange [:mstange]]

Example profile: https://share.firefox.dev/3mJ8kDM

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1666617 - Move kFlushTypeNames into FlushType.h so that it can be used from other files. r=smaug

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1666617 - Allow creating MarkerInnerWindowId with a Maybe<uint64_t>. r=gerald

Depends on D91078

Comment 5

[Markus Stange [:mstange]]

Attachment: Bug 1666617 - Add an observer description argument to AddRefreshObserver. r=smaug

Depends on D91059

Comment 6

[Markus Stange [:mstange]]

Added refresh observer string descriptions: https://share.firefox.dev/3mLIPld

Comment 7

[Markus Stange [:mstange]]

Oh, I just realized that there are many RefreshDriver observer kinds which do not go through AddRefreshObserver, but do end up being respected by HasObservers(). For example, mPendingFullscreenEvents comes from ScheduleFullscreenEvent().

Comment 8

[Markus Stange [:mstange]]

Attachment: Bug 1666617 - Add refresh observer descriptions to the RefreshDriverTick markers. r=smaug

Depends on D91082

Comment 9

[Markus Stange [:mstange]]

Attachment: Bug 1666617 - Fix a typo in the word viewport. r=smaug

Depends on D91379

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31c23ad979bf
Move kFlushTypeNames into FlushType.h so that it can be used from other files. r=smaug
https://hg.mozilla.org/integration/autoland/rev/d1c2e8215817
Allow creating MarkerInnerWindowId with a Maybe<uint64_t>. r=gerald
https://hg.mozilla.org/integration/autoland/rev/36006654190e
Add RefreshObserver profiler markers, r=smaug
https://hg.mozilla.org/integration/autoland/rev/049367bd2e8a
Add an observer description argument to AddRefreshObserver. r=smaug
https://hg.mozilla.org/integration/autoland/rev/549cb9b27480
Add refresh observer descriptions to the RefreshDriverTick markers. r=smaug
https://hg.mozilla.org/integration/autoland/rev/e016eb0691ad
Fix a typo in the word viewport. r=smaug

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/31c23ad979bf
https://hg.mozilla.org/mozilla-central/rev/d1c2e8215817
https://hg.mozilla.org/mozilla-central/rev/36006654190e
https://hg.mozilla.org/mozilla-central/rev/049367bd2e8a
https://hg.mozilla.org/mozilla-central/rev/549cb9b27480
https://hg.mozilla.org/mozilla-central/rev/e016eb0691ad