1666630 - Newtab story personalization to use server defined topics attached to the story

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Scott [:thecount] Downe]

Right now v2 personalization generates a list of topics.

The server is already providing a list of topics. We should use them if they are available.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1666630 - Server defined IAB categories attached to Pocket stories.

Comment 2

[Scott [:thecount] Downe]

(Sorry for the complex list of steps, but this has a few moving pieces)

To test:

1. Set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
2. Set browser.newtabpage.activity-stream.discoverystream.endpoints to "http,https"
3. Set browser.newtabpage.activity-stream.discoverystream.spocs-endpoint to "https://e5e8374d-fffa-4a77-a604-31603852b6fd.mock.pstmn.io/spocs/v2IAB"
4. Set browser.newtabpage.activity-stream.discoverystream.personalization.version to 2
5. Restart
6. Open about:home#devtools-ds
7. Click "refresh cache"
8. Click "Expire Cache", and wait a ~5 seconds.
9. Click "Trigger Idle Daily", and wait a ~5 seconds.
10. Click "Trigger System Tick", and wait a ~5 seconds.
11. Refresh
12. Scroll down to "spoc data"
13. Expand the only spoc in the list, should have the id "74367"
14. Look in the data for "scorableItem"

Expected: it should have "entertainment": 1 in its "item_tags"

Comment 3

[Gavin Suntop [:gvn] (they/them)]

FWIW I had to refresh twice at step 11.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46628da334ce
Server defined IAB categories attached to Pocket stories. r=gvn

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/46628da334ce

Comment 6

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the "entertainment":1 is correctly displayed under the "item_tags" in the "scorableItem" section by following the steps provided in comment 2 and setting the "browser.search.region" pref value to "US" using Firefox Nightly 84.0a1 (Build ID: 20201116094341) on Windows 10 x64, macOS 10.15.6, and Ubuntu Linux 20.04 x64.