166666 - Check for representative file to verify GRE is installed

Status: VERIFIED FIXED

(Core Graveyard :: Installer: GRE, defect)

Description

[Curt Patrick (gone)]

Currently it just looks for the apps folder.  But when the app installs mre we
are registering a file that can be verified.  We should make use of this
information to do a further check.  (See SetInstallFilesVar function in extra.c)
 While we are at it we should probably rename this function and have it return a
boolean instead of setting the variable in the function.

Comment 1

[Curt Patrick (gone)]

The summary was misleading.  Checking for the file which the app registers is an
uninstall issue and the uninstaller is already making use of that data poitn. 
This bug has to do with determining if GRE has already been installed by another
app.

Comment 2

[Curt Patrick (gone)]

Attachment: Patch 1

This turned out to be a very easy fix.	I didn't realize that we already have a
ProgamFile variable defined.

Comment 3

[[e-mail] (away - not reading bugmail)]

Comment on attachment 104026 [details] [diff] [review]
Patch 1

r=jbetak

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 104026 [details] [diff] [review]
Patch 1

>+  if(FileExists(szProgramPath))
>     sgProduct.bInstallFiles = FALSE;
> }

But don't forget in another patch you're trying to add a
force-install check to this if() -- potential for patch
conflict if you're maintaining these separately

sr=dveditz

Comment 5

[Asa Dotzler [:asa]]

please hold until 1.3alpha opens (real soon now). Thanks.

Comment 6

[Curt Patrick (gone)]

Checked in.

Comment 7

[Charles Rosendahl]

Verified