1666676 - Use fully-qualified names for all lookups performed by DoH heuristics.

Status: RESOLVED FIXED

(Firefox :: Security, defect, P1)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

Currently none of the names we look up are including the trailing dot that's required for them to be fully-qualified. There's reason to believe this might lead to errors/anomalies on certain environments, and it's best practice in any case to use fully-qualified names for purposes like this. We should add the trailing dots.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1666676 - Use fully-qualified names for all lookups performed by DoH heuristics. r=valentin!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d0db31be648
Use fully-qualified names for all lookups performed by DoH heuristics. r=valentin

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failure on browser_cleanFlow.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/6ca662e9772173a4eaa769e079378b7e5d85b1a2
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316490279&repo=autoland&lineNumber=2705

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91cb50a045f3
Use fully-qualified names for all lookups performed by DoH heuristics. r=valentin

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/91cb50a045f3