1666701 - 82.0b1 FTBFS in authenticator-rs crate

Status: RESOLVED FIXED

(Core :: DOM: Web Authentication, defect, P1)

Description

[Landry Breuil (:gaston)]

complete error message:

error[E0433]: failed to resolve: use of undeclared type or module `io`                                                 
   --> /usr/obj/ports/firefox-82.0beta1/firefox-82.0/third_party/rust/authenticator/src/openbsd/device.rs:134:49       
    |                                                                                                                  
134 |     fn get_property(&self, _prop_name: &str) -> io::Result<String> {                                             
    |                                                 ^^ use of undeclared type or module `io`                         
                                                                                                                       
error[E0433]: failed to resolve: use of undeclared type or module `io`                                                 
   --> /usr/obj/ports/firefox-82.0beta1/firefox-82.0/third_party/rust/authenticator/src/openbsd/device.rs:135:28       
    |                                                                                                                  
135 |         Err(io::Error::new(io::ErrorKind::Other, "Not implemented"))                                             
    |                            ^^ use of undeclared type or module `io`                                              
                                                                                                                       
error[E0433]: failed to resolve: use of undeclared type or module `io`                                                 
   --> /usr/obj/ports/firefox-82.0beta1/firefox-82.0/third_party/rust/authenticator/src/openbsd/device.rs:135:17       
    |                                                                                                                  
135 |         Err(io::Error::new(io::ErrorKind::Other, "Not implemented"))                                             
    |                 ^^^^^ not found in `io`                                                                          
    |                                                                                                                  
help: consider importing one of these items                                                                            
    |                                                                                                                  
7   | use core::fmt::Error;                                                                                            
    |                                                                                                                  
7   | use crate::capi::thread::thread::env::os_imp::path::fs::fs_imp::Error;                                           
    |                                                                                                                  
7   | use crate::platform::device::mem::fmt::Error;                                                                    
    |                                                                                                                  
7   | use crate::u2ftypes::log::error::Error;                                                                          
    |                                                                                                                  
      and 4 other candidates                                                                                           
                                                                                                                       
error: aborting due to 3 previous errors                                                                               
                                                                                                                       
For more information about this error, try `rustc --explain E0433`.                                                    
error: could not compile `authenticator`.    

potential fix i'm testing: adding use std::io; like in https://github.com/mozilla/authenticator-rs/blob/c270f850382732eeea5a2ee1d74e51fca4ad146c/src/freebsd/device.rs#L8

Comment 1

[Landry Breuil (:gaston)]

or related to https://github.com/mozilla/authenticator-rs/issues/94 instead of throwing an error.

Comment 2

[J.C. Jones [:jcj] (he/him)]

I pulled those lines out at the insistence of clippy as unnecessary use statements, and my cross build to freebsd doesn't complain.

I can go add them back and go for an uplift -- I'll post a new release in https://github.com/mozilla/authenticator-rs/issues/139 -- It might take a few days. While I do that, can you just let me know what version of Rust you're compiling with?

Comment 3

[Landry Breuil (:gaston)]

adding back use std::io works here, added it locally in https://cgit.rhaalovely.net/mozilla-firefox/tree/patches/patch-third_party_rust_authenticator_src_openbsd_device_rs?h=beta&id=61069b70638d71cacd7efbb0f62420874869e4c0

openbsd has rust 1.46.0 - if clippy insists on removing them, maybe it needs teaching about tier3 platforms ? :D

Comment 4

[J.C. Jones [:jcj] (he/him)]

[Tracking Requested - why for this release]:

OOOF. I thought this was FreeBSD.

My cross-check scripts has:

...
cargo build --target x86_64-apple-ios

echo "Remember, no OpenBSD checking! be careful."

Still, clippy, why clippy, why?

Alright, let's plan for a Beta uplift to fix OpenBSD. I'll get the point release together this week.

Comment 5

[Julien Cristau [:jcristau] (back April 22)]

JC, are you able to get to this this week?

Comment 6

[Landry Breuil (:gaston)]

sigh. would be good to have it fixed in 82 though, would be a pity to carry yet another patch..

Comment 7

[J.C. Jones [:jcj] (he/him)]

I'm really sorry i dropped this, gaston - I was PTO last W-F and had too many fires pop up (incl some during PTO, sigh)

I'm preparing the uplift now.

Comment 8

[J.C. Jones [:jcj] (he/him)]

Attachment: Bug 1666701 - Upgrade Authenticator-rs to v0.3.1 r?kjacobs,keeler

This patch fixes a failure to compile on OpenBSD, and also includes the new
(and not yet used by Gecko) WebDriver implementation, and its associated
error-code upgrades.

This has a lot of new packages added into the cargo-checksum, but they were
already used by Gecko, and thus don't change the gecko-wide Cargo.{lock,toml}
files.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c78a3e7cae9
Upgrade Authenticator-rs to v0.3.1 r=kjacobs,keeler

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6c78a3e7cae9