1666766 - Add ApplicationBuildID string as a crash annotation

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, enhancement)

Comment 1

[Roger Yang [:royang]]

Attachment: Data Review.txt

Comment 2

[Roger Yang [:royang]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d95f55aab14d0bab16eede4ffc7ab8d30fa88329

Comment 3

[Roger Yang [:royang]]

Attachment: Bug 1666766 - Add ApplicationBuildID annotation for determining builds that are affected by a crash. r=gsvelto!

Comment 4

[Gabriele Svelto [:gsvelto]]

I'm a bit confused, what version number will go in this new annotation? Is it something different from the build ID and regular version number?

Comment 5

[Roger Yang [:royang]]

I was unsure between naming this annotation "AppBuildID" or "VersionCode".
Version Code is a number that is monotonically increased with each release. They are not very similar to a build ID but Android specific. I decided to use "VersionCode" since it is very specific to avoid confusion.

Comment 6

[Gabriele Svelto [:gsvelto]]

Alright, so it's the code of the Android application, say you have Focus version Y based on Gecko version X then VersionCode will be Y, correct?

Comment 7

[Roger Yang [:royang]]

Yes, the VersionCode will not be based on Gecko. It will be base on the specific release of the app. Thanks,

Comment 8

[Gabriele Svelto [:gsvelto]]

OK, let's give it a more expressive name, what do you think about EmbeddingAppVersion or EmbeddingApplicationVersion or something along the lines? Just to make it super-clear that this isn't about Gecko.

Comment 9

[Roger Yang [:royang]]

Sure, how about ApplicationBuildID?

Comment 10

[Gabriele Svelto [:gsvelto]]

+1

Comment 11

[Roger Yang [:royang]]

I'll update. Thanks!

Comment 12

[Roger Yang [:royang]]

Attachment: Data Review.txt

Comment 13

[Roger Yang [:royang]]

Attachment: Data Review.txt

Comment 14

[Jeff Boek [:boek]]

Comment on attachment 9177888 [details]
Data Review.txt

Data Review Form (to be filled by Data Stewards)

Instructions: Data Stewards will review a request for data collection and endorse responses to each question. If the request does not provide answers to questions, reviewers give an r- and point to the questions that can’t be answered.

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
   Yes in CrashAnnotations.yaml

2. Is there a control mechanism that allows the user to turn the data collection on and off?
   APIs for client applications to control collection.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?
   permanent. a-c (Roger Yang) will monitor.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
   Cat 1

5. Is the data collection request for default-on or default-off?
   Based on the client application.

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
   no

7. Is the data collection covered by the existing Firefox privacy notice?
   yes

8. Does there need to be a check-in in the future to determine whether to renew the data?
   no

9. Does the data collection use a third-party collection tool?
   no

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2048c1c89ba7
Add ApplicationBuildID annotation for determining builds that are affected by a crash. r=gsvelto

Comment 16

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/2048c1c89ba7

Comment 17

[Hector Zhao [:hectorz]]

Hi, I cannot seem to query crashes based on this field in socorro, necessary server side changes are not yet made?

Comment 18

[Will Kahn-Greene [:willkg] ET needinfo? me]

I haven't made the changes on Socorro. I wrote up bug #1684164 for that work. Comment in that bug if you have other needs for this field on Crash Stats.