1666827 - Clicking on a link in the preview browser will navigate the preview browser

Status: VERIFIED FIXED

(Core :: Print Preview, defect, P1)

Description

[Mark Striemer [:mstriemer]]

Attachment: navigate-in-preview.mp4

STR

1. Open a page with a link on it (maybe https://en.wikipedia.org/wiki/Firefox)
2. Start a print
3. Click on a link in the preview browser

Expected results: Nothing happens
Actual results: The preview browser is navigated

Mozregression pointed to this pushlog https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=be24fd0c7bc5f87b103ef59141bcf539bf07c635&tochange=168ce28f004948c7b2646d5f613c1bda7af62de6

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1663826

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Sounds like this is an Emilio fix…

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: Bug 1666827. Prevent user events navigating the print preview document. r=emilio

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1666827 - Make nsDocShell::mIsPrintPreview a flag in the top browsing context. r=smaug

This should make it work on fission, plus is simpler than the
alternative of traversing the whole docshell tree and then undo it.

It also is going to make easier the actual fix for this bug.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1666827 - Mark browsing contexts where we host static documents as "printing". r=smaug

This prevents e.g. navigating the print preview document.

I can try to come up with a test for this, though testing for something
not happening is always a bit more annoying... :)

Depends on D91438

Comment 6

[Jonathan Watt [:jwatt]]

Just a (likely unnecessary) reminder to land this when you can. :-)

Comment 7

[Emilio Cobos Álvarez (:emilio)]

I need to add tests per the phab comments.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1666827 - Tests. r=smaug

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da2d1fb17ef6
Make nsDocShell::mIsPrintPreview a flag in the top browsing context. r=smaug
https://hg.mozilla.org/integration/autoland/rev/6d531a160b56
Mark browsing contexts where we host static documents as "printing". r=smaug

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce43b034a221
Tests. r=smaug

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing browser-chrome's browser_preview_navigate.js:

https://hg.mozilla.org/integration/autoland/rev/cb70b150fd87570545760dfd06078d3201b44e30

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=ce43b034a221733e6d7c797ed8c6609a28d6ec9d&selectedTaskRun=aa4nw5j0THypBa0--OBNtQ.0
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=316898111&repo=autoland
[task 2020-09-28T11:20:56.550Z] 11:20:56 INFO - TEST-PASS | toolkit/components/printing/tests/browser_preview_navigate.js | There shouldn't be any print preview browser -
[task 2020-09-28T11:20:56.552Z] 11:20:56 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "data:text/html,<a href="https://example.com">Navigate away</a>" line: 0}]
[task 2020-09-28T11:20:56.552Z] 11:20:56 INFO - waiting for print
[task 2020-09-28T11:20:56.552Z] 11:20:56 INFO - waiting for preview to finish
[task 2020-09-28T11:20:56.552Z] 11:20:56 INFO - waiting for useless click
[task 2020-09-28T11:20:56.552Z] 11:20:56 INFO - Buffered messages logged at 11:20:12
[task 2020-09-28T11:20:56.553Z] 11:20:56 INFO - waiting for useful click
[task 2020-09-28T11:20:56.553Z] 11:20:56 INFO - waiting for tab to open
[task 2020-09-28T11:20:56.553Z] 11:20:56 INFO - Buffered messages finished
[task 2020-09-28T11:20:56.553Z] 11:20:56 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/printing/tests/browser_preview_navigate.js | Test timed out -

Comment 12

[Emilio Cobos Álvarez (:emilio)]

grr....

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/da2d1fb17ef6
https://hg.mozilla.org/mozilla-central/rev/6d531a160b56

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9177898 [details]
Bug 1666827 - Make nsDocShell::mIsPrintPreview a flag in the top browsing context. r=smaug

Beta/Release Uplift Approval Request

• User impact if declined: print preview can be navigated away
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple-ish refactoring.
• String changes made/needed: none

Comment 15

[Emilio Cobos Álvarez (:emilio)]

(I still need to make sure I land those tests)

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82da4e925317
Tests. r=smaug

Comment 17

[Razvan Maries]

Bakced out for perma failures.

Push with failrues: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=WpdPrioMR2q7oCdRlbiWvw.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=d1efb31f500b6b4c09ec803962f53ff8f3feb974&searchStr=bc

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317127891&repo=autoland&lineNumber=4304

Backout: https://hg.mozilla.org/integration/autoland/rev/83f5f722a365c1e6073a794cf69d175ded1bafed

Comment 18

[Julien Cristau [:jcristau]]

Comment on attachment 9177898 [details]
Bug 1666827 - Make nsDocShell::mIsPrintPreview a flag in the top browsing context. r=smaug

print preview fix, for 82.0b6

Comment 19

[Julien Cristau [:jcristau]]

This doesn't graft cleanly to beta due to conflicts with bug 1557645, please provide a rebased patch.

Comment 20

[Emilio Cobos Álvarez (:emilio)]

Attachment: Beta patch.

Comment 21

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/35148bf2a55c

Comment 22

[Anca Soncutean, Desktop QA]

Reproduced with Fx 83.0a1 (2020-09-23) on Windows 10.
Verified fixed with Fx 82.0.2, Fx 83.0b7 and 84.0a1 (20201101092255) on Windows 10, Ubuntu 18 and macOS 10.15. Note that the behavior mentioned in 1668769 is still reproducible with the latest builds.