1666831 - engine-override.xml can be removed as it can be replaced by engine.xml

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

test_remove_profile_engine.js is the only test that references engine-override.xml:

https://searchfox.org/mozilla-central/search?q=engine-override.xml&path=test&case=false&regexp=false

The test doesn't actually use the information in the file, just the file itself. Therefore we could replace the reference to engine.xml and remove engine-override.xml.

To help us out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
2. Follow the guide for contributing: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
   • If you have any problems, please ask on Matrix in the #introduction channel. They're there to help you get started.
3. Fix the bug as described above, then build and run tests:
   • ./mach build
   • ./mach xpcshell-test toolkit/components/search
4. Create a commit of the changes:
   • $ hg commit -m "Bug nnn - engine-override.xml can be removed as its can be replaced by engine.xml. r?Standard8"
5. Post the commit as per the contributing guide.
6. Once the patches are submitted, I'll take a look. If there's any changes necessary I'll comment in Phabricator, so be prepared to update the patches.
   • If you do need to update the commit, please amend the existing commit, rather than creating new ones. This helps with tracking of review comments.
7. Once we're happy with the changes, I'll push it to autoland - our integration branch. It then gets integrated into our main branch in about 48 hours.
8. Now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.

Comment 1

[Sonia Singla :soniasingla]

Can I send patch here? (not-my-first-bug) but let me know :)

Comment 2

[Mark Banner (:standard8)]

Ok, its been a while and no-one else has grabbed it, so lets get this done.

Comment 3

[Sonia Singla :soniasingla]

Attachment: Bug 1666831 - engine-override.xml can be removed as its can be replaced by engine.xml. r?Standard8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac332d70d5d7
engine-override.xml can be removed as its can be replaced by engine.xml. r=Standard8

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/ac332d70d5d7