[wpt-sync] Sync PR 25719 - Fix tests that return values to async_test in webrtc/
Categories
(Core :: WebRTC, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 25719 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/25719
Details from upstream follow.
b'Stephen McGruer <smcgruer@chromium.org>' wrote:
Fix tests that return values to async_test in webrtc/
These tests are written correctly, they just need to not return the
promises they use as part of the flow.They could be rewritten to use promise_tests if desired, but that would
have performance implications (as it changes them from concurrent to
sequential) so leaving that for now.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 4 tests and 6 subtests
Status Summary
Firefox
OK : 3
PASS : 14
FAIL : 6[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] 18[GitHub]
TIMEOUT: 2
NOTRUN : 5
Chrome
OK : 4
PASS : 32
FAIL : 6
Safari
OK : 4
PASS : 19
FAIL : 19
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
Firefox-only Failures
/webrtc/RTCPeerConnection-track-stats.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], TIMEOUT [GitHub]
addTrack() without setLocalDescription() yields track stats: FAIL
addTrack() with setLocalDescription() yields track stats: FAIL
O/A exchange yields outbound RTP stream stats for sending track: FAIL
O/A exchange yields inbound RTP stream stats for receiving track: FAIL
RTCRtpSender.getStats() contains only outbound-rtp and related stats: TIMEOUT
RTCRtpReceiver.getStats() contains only inbound-rtp and related stats: NOTRUN
RTCPeerConnection.getStats(sendingTrack) is the same as RTCRtpSender.getStats(): NOTRUN
RTCPeerConnection.getStats(receivingTrack) is the same as RTCRtpReceiver.getStats(): NOTRUN
/webrtc/RTCPeerConnection-getStats.https.html
getStats() with no argument should return stats report containing peer-connection stats on an empty PC: FAIL
New Tests That Don't Pass
/webrtc/RTCPeerConnection-track-stats.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: OK)
addTrack() without setLocalDescription() yields track stats: FAIL (Chrome: PASS, Safari: PASS)
addTrack() without setLocalDescription() yields media stream stats: FAIL (Chrome: PASS, Safari: FAIL)
addTrack() with setLocalDescription() yields track stats: FAIL (Chrome: PASS, Safari: PASS)
addTrack() with setLocalDescription() yields media stream stats: FAIL (Chrome: PASS, Safari: FAIL)
addTrack(): Media stream stats references track stats: FAIL (Chrome: PASS, Safari: FAIL)
Media stream stats references track stats: FAIL (Chrome: PASS, Safari: FAIL)
O/A exchange yields outbound RTP stream stats for sending track: FAIL (Chrome: PASS, Safari: PASS)
O/A exchange yields inbound RTP stream stats for receiving track: FAIL (Chrome: PASS, Safari: PASS)
replaceTrack() before offer: new track attachment stats present: FAIL (Chrome: PASS, Safari: FAIL)
replaceTrack() after offer, before answer: new track attachment stats present: FAIL (Chrome: PASS, Safari: FAIL)
replaceTrack() after answer: new track attachment stats present: FAIL (Chrome: PASS, Safari: FAIL)
replaceTrack(): original track attachment stats present after replacing: FAIL (Chrome: FAIL, Safari: FAIL)
RTCRtpSender.getStats() contains only outbound-rtp and related stats: TIMEOUT (Chrome: PASS, Safari: PASS)
RTCRtpReceiver.getStats() contains only inbound-rtp and related stats: NOTRUN (Chrome: PASS, Safari: PASS)
RTCPeerConnection.getStats(sendingTrack) is the same as RTCRtpSender.getStats(): NOTRUN (Chrome: PASS, Safari: PASS)
RTCPeerConnection.getStats(receivingTrack) is the same as RTCRtpReceiver.getStats(): NOTRUN (Chrome: PASS, Safari: PASS)
RTCPeerConnection.getStats(track) throws InvalidAccessError when there are zero senders or receivers for the track: NOTRUN (Chrome: PASS, Safari: FAIL)
RTCPeerConnection.getStats(track) throws InvalidAccessError when there are multiple senders for the track: NOTRUN (Chrome: PASS, Safari: FAIL)
/webrtc/legacy/RTCPeerConnection-addStream.https.html
Legacy addStream(): Media stream stats references track stats: FAIL (Chrome: PASS, Safari: FAIL)
/webrtc/RTCPeerConnection-getStats.https.html
getStats() with no argument should return stats report containing peer-connection stats on an empty PC: FAIL (Chrome: PASS, Safari: PASS)
getStats() with no argument should return stats for no-stream tracks: FAIL (Chrome: FAIL, Safari: FAIL)
getStats() on track associated with RtpSender should return stats report containing outbound-rtp stats: FAIL (Chrome: FAIL, Safari: FAIL)
getStats() on track associated with RtpReceiver should return stats report containing inbound-rtp stats: FAIL (Chrome: FAIL, Safari: FAIL)
getStats() with connected peer connections having tracks and data channel should return all mandatory to implement stats: FAIL (Chrome: FAIL, Safari: FAIL)
Tests Disabled in Gecko Infrastructure
/webrtc/RTCPeerConnection-track-stats.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: OK)
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Description
•