Closed Bug 1666840 Opened 8 months ago Closed 5 months ago

Move invalid-engine.xml to the OpenSearch test sub-directory

Categories

(Firefox :: Search, task, P3)

Product:
Firefox
Component:
Search
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox86 --- fixed

People

(Reporter: standard8, Assigned: baka, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file)

Bug 1666840 - Move invalid-engine.xml to the OpenSearch test sub-directory. r?Standard8
48 bytes, text/x-phabricator-request
Details | Review

invalid-engine.xml is only referenced by OpenSearch tests:

https://searchfox.org/mozilla-central/search?q=invalid-engine.xml&path=toolkit%2Fcomponents%2Fsearch%2Ftests&case=false&regexp=false

We should move it from toolkit/components/search/tests/xpcshell/data/invalid-engine.xml to toolkit/components/search/tests/xpcshell/opensearch/invalid.xml and update the references.

To help us out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
  2. Follow the guide for contributing: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
    • If you have any problems, please ask on Matrix in the #introduction channel. They're there to help you get started.
  3. Fix the bug as described above, then build and run tests:
    • ./mach build
    • ./mach xpcshell-test toolkit/components/search
  4. Create a commit of the changes:
    • $ hg commit -m "Bug nnn - Move invalid-engine.xml to the OpenSearch test sub-directory. r?Standard8"
  5. Post the commit as per the contributing guide.
  6. Once the patches are submitted, I'll take a look. If there's any changes necessary I'll comment in Phabricator, so be prepared to update the patches.
    • If you do need to update the commit, please amend the existing commit, rather than creating new ones. This helps with tracking of review comments.
  7. Once we're happy with the changes, I'll push it to autoland - our integration branch. It then gets integrated into our main branch in about 48 hours.
  8. Now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.
Keywords: good-first-bug

I would like to work on this card.please assign to me if needed
Thanks!!

Hi Vivek, yes please do.

Assignee: nobody → erpandey

Hello Mark, can I work on this bug? Please assign this to me if needed.

(In reply to Mark Banner (:standard8) from comment #2)

Hi Vivek, yes please do.

Hello Mark, If vivek is no longer working on this bug please assign this to me. (:standard8)

Assignee: erpandey → akshat.dixit71
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fe0b2cded866
Move invalid-engine.xml to the OpenSearch test sub-directory. r=Standard8

https://hg.mozilla.org/mozilla-central/rev/fe0b2cded866

Status: NEW → RESOLVED
Closed: 5 months ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.