Closed
Bug 1666873
Opened 4 years ago
Closed 4 years ago
MOZ_PGO local builds fail in build_commands.py
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox-esr78 unaffected, firefox81 unaffected, firefox82 fixed, firefox83 fixed)
RESOLVED
FIXED
83 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox81 | --- | unaffected |
| firefox82 | --- | fixed |
| firefox83 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
When trying to use MOZ_PGO in mozconfig file I get failures due to missing self.metrics argument in https://searchfox.org/mozilla-central/rev/3d53187b90605ccef321c9cadbba762ad06a6381/python/mozbuild/mozbuild/build_commands.py#90-97,124-132
|
Assignee | |
Comment 1•4 years ago
|
||
This argument was recently added to the normal build invocation below but was
missed in the MOZ_PGO branch.
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/061c409a4388 Add missing self.metrics argument for local MOZ_PGO build_commands r=firefox-build-system-reviewers,mhentges
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
|
||
Comment 4•4 years ago
|
||
Set release status flags based on info from the regressing bug 1654074
status-firefox81:
--- → affected
status-firefox82:
--- → affected
status-firefox-esr78:
--- → unaffected
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 6•4 years ago
|
||
Comment on attachment 9177451 [details]
Bug 1666873 - Add missing self.metrics argument for local MOZ_PGO build_commands
Beta/Release Uplift Approval Request
- User impact if declined: PGO builds will fail.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Fixes unconditional exception by passing an additional argument without performing any other work.
- String changes made/needed:
Attachment #9177451 -
Flags: approval-mozilla-beta?
|
|
||
Updated•4 years ago
|
Keywords: regression
|
||
Comment 7•4 years ago
|
||
Comment on attachment 9177451 [details]
Bug 1666873 - Add missing self.metrics argument for local MOZ_PGO build_commands
approved for 82.0b4
Attachment #9177451 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
|
||
Comment 8•4 years ago
|
||
| bugherder uplift | ||
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•