1666874 - Skeleton UI does not correctly handle maximized windows

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Alex Thayer [:alexical] (she/her)]

NOTE: this is behind the currently disabled Windows skeleton UI feature.

• Turn on the skeleton UI pref
• Maximize the window
• Close and reopen Firefox
• Notice that the skeleton UI window is not maximized

Comment 1

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1666874 - Support maximized windows for skeleton UI r?agashlin

Most of this patch is a dance to avoid size flickering of the skeleton UI
window. We change all Resize/Move/SetSizeMode calls from before the first
nsWindow::Show call. Normally those have no effect, since the window isn't
shown yet, and if the window is not maximized, they typically match the
sizes we've gotten out of the registry anyway. However, if we are maximized,
then they produce a lot of visual noise. We can however achieve the desired
effect by just calling SetWindowPlacement.

Similarly, we switch the window styles of the skeleton UI window to match those
of the toplevel Windows window, and adjust the client rect from our window proc
in a way that matches the adjustments in nsWindow in the WM_NCCALCSIZE handler.
We do this because otherwise we get a flicker as soon as we change the styles
and nonclient margins as the fake chrome pops up and then back down.

Lastly we also change the extended window styles so that they match. We
historically added WS_EX_TOOLWINDOW here to hide the toolbar entry, because it
would otherwise switch out to a new toolbar entry when we changed the window
styles. However since our new styles match, we no longer need to do this. It
was also causing the maximized window to paint over the Windows taskbar.

Depends on D91453

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/967c4cf56fd2
Support maximized windows for skeleton UI r=agashlin

Comment 3

[Atila Butkovits]

Backed out for causing bustage on PreXULSkeletonUI.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/11b392ab3df5e1804c21fb39180fa9ee1f19d816

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=anDkaV9MTYmiRYVHGyP7Lw.0&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=spidermonkey&revision=967c4cf56fd2d8b8f6875386550bbe51f1ffcf4f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=320136160&repo=autoland&lineNumber=5012

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23c5d0a4118e
Support maximized windows for skeleton UI r=agashlin

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/23c5d0a4118e