Closed
Bug 1666878
Opened 4 years ago
Closed 4 years ago
logging from osclientcerts isn't thread-safe, can lead to confusing logs
Categories
(Core :: Security: PSM, defect, P1)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
83 Branch
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: keeler, Assigned: keeler)
References
(Blocks 1 open bug)
Details
(Whiteboard: [psm-assigned])
Attachments
(1 file)
Logging from osclientcerts in lib.rs isn't protected by a lock of any kind, so log lines can end up interspersed, which can be confusing.
|
Assignee | |
Comment 2•4 years ago
|
||
A large portion of osclientcerts runs on a single thread, but the C API in
lib.rs doesn't. Thus, log lines from different threads can be interlaced,
causing confusion. This patch includes the current thread in those logs so they
can be de-interlaced.
|
|
Assignee | |
Updated•4 years ago
|
Priority: -- → P1
Pushed by dkeeler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f90b00365481 osclientcerts: include the current thread id in logging in lib.rs r=kjacobs
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•