1666887 - Pocket's "Saving" and "Page Removed" door hangers have white and gray rectangles at the bottom

Status: VERIFIED FIXED

(Firefox :: Pocket, defect, P1)

Description

[Chris Peterson [:cpeterson]]

Attachment: Saving_screenshot.png

Steps to reproduce

1. Click the "Save to Pocket" address bar button.
2. BUG: The "Saving" door hanger" has a big white rectangle at the bottom.
3. Click the "Saved to Pocket" door hanger's "Remove Page" button.
4. BUG: The "Page Removed" door hanger has a small gray rectangle at the bottom.

See the attached screenshots.

This is a regression in Fx82.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Page_Removed_screenshot.png

Comment 2

[Chris Peterson [:cpeterson]]

I tried to bisect this regression using mozregression, but I can't reproduce the bug in a clean Firefox profile (that is logged into the same FxA Pocket account I used in my other copies of Firefox 82 Nightly, 81 Beta, and 80 Release).

Comment 3

[Cristian Fogel [:cfogel]]

Notes:

• from what I noticed the rectangle is fairly visible even after step 2;
• issue confirmed on Windows 10/macOS 11.0 as well.

Regression range:

• last good: 2020-09-16;
• first bad: 2020-09-17;
• pushlog: URL;
• Potential regressor: bug 1655123.

@Gavin, mind confirming if this is accurate?
Thanks in advance!

Comment 4

[Gavin Suntop [:gvn] (they/them)]

Attachment: Bug 1666887 - Fixing empty grey rectangles in UI

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/056f80dc2e5e
Fixing empty grey rectangles in UI r=thecount

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/056f80dc2e5e

Comment 7

[Scott [:thecount] Downe]

Comment on attachment 9178590 [details]
Bug 1666887 - Fixing empty grey rectangles in UI

Beta/Release Uplift Approval Request

• User impact if declined: UI/UX improvements to a feature we are looking to pref on.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Click the "Save to Pocket" address bar button.

2. BUG: The "Saving" door hanger" has a big white rectangle at the bottom.
3. Click the "Saved to Pocket" door hanger's "Remove Page" button.
4. BUG: The "Page Removed" door hanger has a small gray rectangle at the bottom.

• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): Mostly css
• String changes made/needed: none

Comment 8

[Alin Ilea, Desktop Test Engineering]

Reproduced the initial issue using Beta build 82.0b5 on Windows 10.
Verified - Fixed in latest Nightly 83.0a1 (build id: 20201001094020) using Windows 10 and Ubuntu 18.04.

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9178590 [details]
Bug 1666887 - Fixing empty grey rectangles in UI

approved for 82.0b7

Comment 10

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f7d88dd9fb18

Comment 11

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Beta 82.0b7 (build id: 20201002191150) using Windows 10 and Ubuntu 18.04.