1666910 - Crashtest 1517025.html triggers reflowOutput.ISize(lineWM) >= 0 assertion (in another test, maybe?)

Status: NEW

(Core :: Layout: Block and Inline, defect)

Description

[Valentin Gosu [:valentin] (he/him)]

See https://phabricator.services.mozilla.com/D16817

(In reply to Emilio Cobos Álvarez (:emilio) from bug 1527126 comment #3)

So those assertions are useful in the sense that they should only fire with degenerate test-case. I'm very confused about how your test-case could trigger it, they likely come from another crashtest? It has nsTableWrapperFrame in the stack and there's no table in your test-case at all...

[task 2020-09-23T12:08:03.063Z] 12:08:03     INFO - #47: nsBlockReflowContext::ReflowBlock(mozilla::LogicalRect const&, bool, nsCollapsingMargin&, int, bool, nsLineBox*, mozilla::ReflowInput&, nsReflowStatus&, mozilla::BlockReflowInput&) [layout/generic/nsBlockReflowContext.cpp:295]
[task 2020-09-23T12:08:03.063Z] 12:08:03     INFO - #48: nsBlockFrame::ReflowBlockFrame(mozilla::BlockReflowInput&, nsLineList_iterator, bool*) [layout/generic/nsBlockFrame.cpp:3834]
[task 2020-09-23T12:08:03.064Z] 12:08:03     INFO - #49: nsBlockFrame::ReflowLine(mozilla::BlockReflowInput&, nsLineList_iterator, bool*) [layout/generic/nsBlockFrame.cpp:3170]
[task 2020-09-23T12:08:03.065Z] 12:08:03     INFO - #50: nsBlockFrame::ReflowDirtyLines(mozilla::BlockReflowInput&) [layout/generic/nsBlockFrame.cpp:2710]
[task 2020-09-23T12:08:03.066Z] 12:08:03     INFO - #51: nsBlockFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) [layout/generic/nsBlockFrame.cpp:1379]
[task 2020-09-23T12:08:03.068Z] 12:08:03     INFO - #52: nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, mozilla::WritingMode const&, mozilla::LogicalPoint const&, nsSize const&, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) [layout/generic/nsContainerFrame.cpp:1079]
[task 2020-09-23T12:08:03.068Z] 12:08:03     INFO - #53: nsCanvasFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) [layout/generic/nsCanvasFrame.cpp:757]
[task 2020-09-23T12:08:03.068Z] 12:08:03     INFO - #54: nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, mozilla::WritingMode const&, mozilla::LogicalPoint const&, nsSize const&, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) [layout/generic/nsContainerFrame.cpp:1079]
[task 2020-09-23T12:08:03.069Z] 12:08:03     INFO - #55: nsHTMLScrollFrame::ReflowScrolledFrame(mozilla::ScrollReflowInput*, bool, bool, mozilla::ReflowOutput*) [layout/generic/nsGfxScrollFrame.cpp:755]
[task 2020-09-23T12:08:03.071Z] 12:08:03     INFO - #56: nsHTMLScrollFrame::ReflowContents(mozilla::ScrollReflowInput*, mozilla::ReflowOutput const&) [layout/generic/nsGfxScrollFrame.cpp:901]
[task 2020-09-23T12:08:03.071Z] 12:08:03     INFO - #57: nsHTMLScrollFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) [layout/generic/nsGfxScrollFrame.cpp:1279]
[task 2020-09-23T12:08:03.071Z] 12:08:03     INFO - #58: nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, int, int, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) [layout/generic/nsContainerFrame.cpp:1115]
[task 2020-09-23T12:08:03.075Z] 12:08:03     INFO - #59: mozilla::ViewportFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) [layout/generic/ViewportFrame.cpp:297]
[task 2020-09-23T12:08:03.075Z] 12:08:03     INFO - #60: mozilla::PresShell::DoReflow(nsIFrame*, bool, mozilla::OverflowChangedTracker*) [layout/base/PresShell.cpp:9659]
[task 2020-09-23T12:08:03.075Z] 12:08:03     INFO - #61: mozilla::PresShell::ProcessReflowCommands(bool) [layout/base/PresShell.cpp:9825]
[task 2020-09-23T12:08:03.075Z] 12:08:03     INFO - #62: mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) [layout/base/PresShell.cpp:4240]
[task 2020-09-23T12:08:03.075Z] 12:08:03     INFO - #63: nsRefreshDriver::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/nsRefreshDriver.cpp:2152]
[task 2020-09-23T12:08:03.075Z] 12:08:03     INFO - #64: mozilla::RefreshDriverTimer::TickRefreshDrivers(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp, nsTArray<RefPtr<nsRefreshDriver> >&) [layout/base/nsRefreshDriver.cpp:346]
[task 2020-09-23T12:08:03.075Z] 12:08:03     INFO - #65: mozilla::RefreshDriverTimer::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/nsRefreshDriver.cpp:369]
[task 2020-09-23T12:08:03.075Z] 12:08:03     INFO - #66: mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::TickRefreshDriver(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/nsRefreshDriver.cpp:748]
[task 2020-09-23T12:08:03.075Z] 12:08:03     INFO - #67: mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::NotifyParentProcessVsync() [layout/base/nsRefreshDriver.cpp:649]
[task 2020-09-23T12:08:03.076Z] 12:08:03     INFO - #68: mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::NotifyVsync(mozilla::VsyncEvent const&) [layout/base/nsRefreshDriver.cpp:569]
[task 2020-09-23T12:08:03.076Z] 12:08:03     INFO - #69: mozilla::layout::VsyncChild::RecvNotify(mozilla::VsyncEvent const&) [layout/ipc/VsyncChild.cpp:57]
[task 2020-09-23T12:08:03.078Z] 12:08:03     INFO - #70: mozilla::layout::PVsyncChild::OnMessageReceived(IPC::Message const&) [s3:gecko-generated-sources-l1:dcfb0c5c8cc64a4b8592c33a9bb2c1a430c98ebd009674a59f93629a7c17a7323253973267a429964267d5e17f515a9e0c9f5ab4ceb87eda82e2dd117c395600/ipc/ipdl/PVsyncChild.cpp::187]
[task 2020-09-23T12:08:03.078Z] 12:08:03     INFO - #71: mozilla::ipc::PBackgroundChild::OnMessageReceived(IPC::Message const&) [s3:gecko-generated-sources-l1:00136e3caf26c4b7c1e02c7d7b5c085f78c5c635ada1f4b4ddbb1f6a4ef65fe4154430e47012562c0e0ce77c38fc9103b2b15d160520930d739c0ef793d6930f/ipc/ipdl/PBackgroundChild.cpp::6080]
[task 2020-09-23T12:08:03.079Z] 12:08:03     INFO - #72: mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&) [ipc/glue/MessageChannel.cpp:2151]
[task 2020-09-23T12:08:03.079Z] 12:08:03     INFO - #73: mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) [ipc/glue/MessageChannel.cpp:2077]
[task 2020-09-23T12:08:03.080Z] 12:08:03     INFO - #74: mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::MessageChannel::MessageTask&) [ipc/glue/MessageChannel.cpp:1922]
[task 2020-09-23T12:08:03.081Z] 12:08:03     INFO - #75: mozilla::ipc::MessageChannel::MessageTask::Run() [ipc/glue/MessageChannel.cpp:1955]
[task 2020-09-23T12:08:03.081Z] 12:08:03     INFO - #76: mozilla::RunnableTask::Run() [xpcom/threads/TaskController.cpp:245]
[task 2020-09-23T12:08:03.082Z] 12:08:03     INFO - #77: mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) [xpcom/threads/TaskController.cpp:514]
[task 2020-09-23T12:08:03.082Z] 12:08:03     INFO - #78: mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) [xpcom/threads/TaskController.cpp:373]
[task 2020-09-23T12:08:03.087Z] 12:08:03     INFO - #79: mozilla::TaskController::ProcessPendingMTTask(bool) [xpcom/threads/TaskController.cpp:170]
[task 2020-09-23T12:08:03.087Z] 12:08:03     INFO - #80: mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_0>::Run() [xpcom/threads/nsThreadUtils.h:578]
[task 2020-09-23T12:08:03.087Z] 12:08:03     INFO - #81: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:1237]
[task 2020-09-23T12:08:03.087Z] 12:08:03     INFO - #82: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/threads/nsThreadUtils.cpp:513]
[task 2020-09-23T12:08:03.087Z] 12:08:03     INFO - #83: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:87]
[task 2020-09-23T12:08:03.087Z] 12:08:03     INFO - #84: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:334]
[task 2020-09-23T12:08:03.087Z] 12:08:03     INFO - #85: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:310]
[task 2020-09-23T12:08:03.087Z] 12:08:03     INFO - #86: nsBaseAppShell::Run() [widget/nsBaseAppShell.cpp:139]
[task 2020-09-23T12:08:03.087Z] 12:08:03     INFO - #87: XRE_RunAppShell() [toolkit/xre/nsEmbedFunctions.cpp:913]
[task 2020-09-23T12:08:03.087Z] 12:08:03     INFO - #88: mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:237]
[task 2020-09-23T12:08:03.087Z] 12:08:03     INFO - #89: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:334]
[task 2020-09-23T12:08:03.087Z] 12:08:03     INFO - #90: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:310]
[task 2020-09-23T12:08:03.091Z] 12:08:03     INFO - #91: XRE_InitChildProcess(int, char**, XREChildData const*) [toolkit/xre/nsEmbedFunctions.cpp:744]
[task 2020-09-23T12:08:03.091Z] 12:08:03     INFO - #92: content_process_main(mozilla::Bootstrap*, int, char**) [ipc/contentproc/plugin-container.cpp:57]
[task 2020-09-23T12:08:03.091Z] 12:08:03     INFO - #93: main [browser/app/nsBrowserApp.cpp:304]

Comment 1

[Daniel Holbert [:dholbert]]

(In reply to Valentin Gosu [:valentin] (he/him) from comment #0)

See https://phabricator.services.mozilla.com/D16817

More directly, see bug 1527126 comment 2 and 3.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: raw log from try run that had the assertion failure (gzipped)