1666918 - Handle Duplicate Paper Sizes Returned By CUPS

Status: RESOLVED FIXED

(Core :: Printing: Setup, enhancement, P3)

Description

[Erik Nordin [:nordzilla]]

CUPS will occasionally return a list containing multiple duplicate paper sizes. I have personally observed this behavior on my Ubuntu 16.04.7 VM, trying to retrieve paper information for my Canon iX6820.

We are currently handling duplicate paper sizes on the front end, but it makes more sense to handle this as close to the source as possible, in the platform code.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1666918 - Prevent Duplicate Paper Sizes Returned From CUPS r=alaskanemily,emilio,jwatt

CUPS occasionally returns duplicate paper sizes, especially on
older versions of Ubuntu. This patch utilizes a hash set to
skip over any dpulciate paper sizes, ensuring that the final list
contains only unique sizes.

These duplicate checks are currently being done on the front end,
and this patch will allow us to remove them.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f101d192e609
Prevent Duplicate Paper Sizes Returned From CUPS r=emilio

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f101d192e609

Comment 4

[Jonathan Watt [:jwatt]]

Given we handle this in the frontend currently, I don't think we need to uplift this. Let me know if you disagree.