Closed Bug 1666983 Opened 5 years ago Closed 5 years ago

`SourceExtent.toStringEnd` isn't set to correct value when delazifying class constructor

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

function f() { class A { constructor() {} } } f()
function f() { class A { constructor() {} } new A() } f()

when delazifying f, the function contains class constructor,
when delazifying A,
class constructor's extent.toStringEnd is set to the end of constructor function itself, not the class.

we don't use the value, but it's better fixing it, or remove the filed in "update" struct.

Severity: -- → N/A
Priority: -- → P3
Severity: N/A → S4
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/5a5bb14b79fe Bug 1666983 - Set ScriptStencil.extent.toStringEnd of class constructor to correct value when delazifying. r=tcampbell
Backout by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7b369792b033 Backed out changeset 5a5bb14b79fe for SM bustages on Stencil.cpp
Attachment #9179550 - Attachment description: Bug 1666983 - Bug 1666983 - Set ScriptStencil.extent.toStringEnd of class constructor to correct value when delazifying. r?tcampbell! → Bug 1666983 - Set ScriptStencil.extent.toStringEnd of class constructor to correct value when delazifying. r?tcampbell!

Forgot to exclude mutable flags in FunctionFlags from the comparison.

Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/602f53c7db5f Set ScriptStencil.extent.toStringEnd of class constructor to correct value when delazifying. r=tcampbell
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: