1666991 - remove PresShell::GetNearestScrollableFrame

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, defect)

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1666991. Remove PresShell::GetNearestScrollableFrame. r?kats

The current formulation is inconsistent. If you call it with ScrollableDirection::Either it goes into nsLayoutUtils::GetNearestScrollableFrame which will return the first scroll frame with a non-hidden overflow. If you call it with any other ScrollableDirection it calls nsLayoutUtils::GetNearestScrollableFrameForDirection which returns the first scrollframe it finds that has non-hidden overflow AND has at least one dev pixel of scroll range.

So remove that function and call nsLayoutUtils::GetNearestScrollableFrameForDirection directly. This is a slight change of behaviour but it seems desirable for all callers.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f533efa80b7
Remove PresShell::GetNearestScrollableFrame. r=kats

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9f533efa80b7