Remove SourceQueue entirely
Categories
(DevTools :: Debugger, enhancement, P3)
Tracking
(Not tracked)
People
(Reporter: ochameau, Unassigned)
References
(Depends on 1 open bug, Blocks 2 open bugs)
Details
Attachments
(2 files)
Bug 1620280 will make the SourceQueue module:
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/utils/source-queue.js
only used for source mapped sources.
But given how it is being used, by queuing source and flushing immediately, we should be able to remove it. Instead we should be able to call newOriginalSources action once, we all mapped sources.
|
Reporter | |
Comment 1•4 years ago
|
||
|
|
Reporter | |
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
Reporter | |
Comment 2•3 years ago
|
||
Removal of source queue was blocked by the possible performance regression of no longer throlling original sources.
Bug 1749763 will extend test coverage to ensure that we decently handle slow loading source map.
Then we should have a higher confidence in dropping it.
We also the opportunity to reuse ResourceCommand throttling mechanism in order to ensure we don't process original sources individual and throttle their processing.
|
|
Reporter | |
Comment 3•3 years ago
|
||
For now, generated sources are SOURCE resources,
but original sources are some custom object internal to the debugger.
It may help overall code comprehension to have both type of sources be
at the same level and both be resources.
Also, here, it would help get rid of SourceQueue from the debugger frontend,
which is yet another way to do throttling. By making original sources
be emitted by the ResourceCommand we would benefit from its builtin throttling mechanism.
The only downside here is that it would be the very first 100% client side generated resource.
The expectation if that all resources are being generated by the server.
We would break that rule and introduce a special codepath for this.
Description
•