Closed Bug 1667117 Opened 5 years ago Closed 5 years ago

openBrowserWindow wrongly uses checkFn for waitForObserverTopic

Categories

(Remote Protocol :: Marionette, defect, P1)

Default
defect

Tracking

(firefox83 fixed)

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

Details

Attachments

(1 file)

Here is the affected code:
https://searchfox.org/mozilla-central/rev/3d53187b90605ccef321c9cadbba762ad06a6381/testing/marionette/browser.js#322-325

The second option is not a callback but an object, which contains a checkFn property the callback needs to be assigned to.

As of right now the check will not be done, and the first opened window is taken.

Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P3 → P1
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1fb7de959c35 [marionette] openBrowserWindow() wrongly uses checkFn for waitForObserverTopic. r=marionette-reviewers,maja_zf
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: