1667122 - Perma browser/base/content/test/static/browser_parsable_css.js | Got error message for resource://gre-resources/mathml.css: Unknown property ‘math-style’. Declaration dropped. when Gecko 83 merges to Beta on 2020-10-19

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedTaskRun=CiuiHaBcQ6yxpMqztMqEDw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=fe26df9ba01855cafb14cd113e2f328b4e345d00&searchStr=browser-chrome

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=316581875&repo=try

TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | Got error message for resource://gre-resources/mathml.css: Unknown property ‘math-style’. Declaration dropped. -

Comment 1

[Frédéric Wang Nélar]

Probably, the test should be adjusted to only test math-style when layout.css.math-style.enabled is enabled. I guess we do something similar for other properties that are only enabled in nightly?

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Yeah, you need a whitelist entry like this: https://searchfox.org/mozilla-central/rev/3d53187b90605ccef321c9cadbba762ad06a6381/browser/base/content/test/static/browser_parsable_css.js

But using math-style as the property name and mathml.css instead of forms.css, and conditional on the pref being false (you can see existing entries below).

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This also causes mochitest-plain failures: https://treeherder.mozilla.org/logviewer.html#?job_id=316582730&repo=try

TEST-UNEXPECTED-FAIL | layout/style/test/test_bug1112014.html | uncaught exception - NS_ERROR_FAILURE: at doApply@resource://specialpowers/WrapPrivileged.jsm:118:18
TEST-UNEXPECTED-FAIL | layout/style/test/test_ch_ex_no_infloops.html | Setting 'math-style' to '3ex' should not cause infinite loop - didn't expect "", but got it
etc.

Comment 4

[Frédéric Wang Nélar]

Attachment: Bug 1667122 - Make CSS tests work when math-style is disabled

Comment 5

[Frédéric Wang Nélar]

Attachment: Bug 1667122 - Make CSS tests work when math-style is disabled. r=emilio

Comment 6

[Frédéric Wang Nélar]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #3)

This also causes mochitest-plain failures: https://treeherder.mozilla.org/logviewer.html#?job_id=316582730&repo=try

TEST-UNEXPECTED-FAIL | layout/style/test/test_bug1112014.html | uncaught exception - NS_ERROR_FAILURE: at doApply@resource://specialpowers/WrapPrivileged.jsm:118:18
TEST-UNEXPECTED-FAIL | layout/style/test/test_ch_ex_no_infloops.html | Setting 'math-style' to '3ex' should not cause infinite loop - didn't expect "", but got it
etc.

These ones seem to use layout/style/test/property_database.js

I've uploaded a tentative patch.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52f73bfae49a
Make CSS tests work when math-style is disabled. r=emilio

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/52f73bfae49a

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0babcd701b43
Port bug 1667122 - Make CSS tests work when math-style is disabled. rs=bustage-fix

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with today's central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=a8213d07f925fa23de8539a12380475f0abdb867