1667280 - Update pdf.js to version 2.7.81

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, task)

Description

[Ryan VanderMeulen [:RyanVM]]

+++ This bug was initially created as a clone of Bug #1665812 +++

Changes since last update:
#12393 Prevent errors if the InkList property, in InkAnnotations, is missing and/or not an Array (issue 12392)
#12396 Update packages and translations
#12397 Update the webpack-stream dependency (issue 11996)
#12414 Need to reset the streams when printing
#12409 Compute the transformOrigin correctly, for negative values, when rendering AnnotationElements (bug 1627030)

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1667280 - Update pdf.js to version 2.7.81. r=bdahl

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1667280 - Need to reset the streams when printing. r=bdahl

This is a cherry-pick of the following upstream commit:
https://github.com/mozilla/pdf.js/pull/12414

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Assume we want to uplift the fix for #12414, I've attached a cherry-pick patch suitable for doing so. It applies cleanly to both beta and release (though I'm not sure this is really reproducible on 81 where the old print UI is the default - I couldn't reproduce even with PDF form filling preffed on).

Try pushes:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd361aa9e6d6c17211bb5c79b55595421921ff6a (m-c 2.7.81 update)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=59b0f89c2ca7051e1101eff713e2e6f413f603f6 (m-b cherry-pick)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=42a58a0c7f8a1a1c9f63bb85a9c22adc19f5b9af (m-r cherry-pick)

I've added builds for all platforms in case QA wants to do any testing too.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f16c5a4ae277
Update pdf.js to version 2.7.81. r=bdahl

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f16c5a4ae277

Comment 6

[Simona Rosu [:srosu], Ecosystem QA, PTO - NI to: [e-mail]]

Thank you Ryan for the provided builds.
We have verified Bug 1666753 and Bug 1666629 using the provided builds on Windows 10 x64, macOS 10.15.6 and Ubuntu 20.04. Here are the results:

• m-c 2.7.81 update: - The bugs are no longer reproducible using this build.
• m-b cherry-pick: - The bugs are no longer reproducible using this build.
• m-r cherry-pick: - We are not able to tick the checkboxes and radio buttons using this build, even if the “pdfjs.renderInteractiveForms” pref is set to true, but the fields are editable.

However, we will also verify the bugs as soon as the patch lands in the latest Nightly build.

Comment 7

[Simona Rosu [:srosu], Ecosystem QA, PTO - NI to: [e-mail]]

I have verified Bug 1666753 and Bug 1666629 and are no longer reproducible using the latest Firefox Nightly 83.0a1 (Build ID: 20200927215113) on Windows 10 x64, Ubuntu 20.04, and Mac 10.15.

• Considering this I will mark this issue as Verified fixed.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Hi Brendan, did you want to nominate the cherry-pick patch for Beta uplift? I'm not sure we need to worry about Release81, but it would probably be good to get this fixed for 82 at least.

Comment 9

[Brendan Dahl [:bdahl]]

Comment on attachment 9177787 [details]
Bug 1667280 - Need to reset the streams when printing. r=bdahl

Beta/Release Uplift Approval Request

• User impact if declined: Some checkboxes/radio buttons will not print correctly in PDFs.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See bug 1666753
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small straightforward code change.
• String changes made/needed:

Comment 10

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9177787 [details]
Bug 1667280 - Need to reset the streams when printing. r=bdahl

approved for 82.0b5

Comment 11

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9177787 [details]
Bug 1667280 - Need to reset the streams when printing. r=bdahl

this landed on beta in https://bugzilla.mozilla.org/show_bug.cgi?id=1666753#c4

Comment 12

[Simona Rosu [:srosu], Ecosystem QA, PTO - NI to: [e-mail]]

I have verified Bug 1666753 and is no longer reproducible using the Firefox Beta 82.0b5 (Build ID: 20200929175845) on Windows 10 x64, Ubuntu 20.04, and Mac 10.15.

• Considering this I will mark the status of firefox82 as verified.